-
Notifications
You must be signed in to change notification settings - Fork 8
Update StablePay SDK for Ethereum Classic support #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR updates the StablePay SDK to support the Ethereum Classic (ETC) Mainnet and renames the existing Ethereum Classic testnet configuration to 'Mordor Testnet' for better clarity and standardization. It addresses Issue StabilityNexus#18 by renaming the network and adding a new configuration entry for Ethereum Classic.
WalkthroughStablePay SDK is updated to support Ethereum Classic Mainnet with chain ID 61, associated RPC and contract addresses. The existing ETC testnet configuration is renamed to "Mordor Testnet" for clarity. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
license.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
license.md
12-12: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
license.md (1)
1-16: PR documentation looks comprehensive.The changes are well-documented with proper verification notes for contract addresses. The Chain ID 61 and RPC endpoint for ETC Mainnet are correctly specified. The rename of the testnet to "Mordor Testnet" provides clarity for standardization.
|
|
||
| Chain ID: 61 | ||
|
|
||
| RPC: https://etc.rivet.link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap the bare URL in markdown link syntax.
The RPC URL should be formatted as a markdown link or wrapped in backticks/angle brackets to comply with markdown standards.
Apply this diff to fix the markdown formatting:
-RPC: https://etc.rivet.link
+RPC: <https://etc.rivet.link>Alternatively, use inline code formatting:
-RPC: https://etc.rivet.link
+RPC: `https://etc.rivet.link`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| RPC: https://etc.rivet.link | |
| RPC: <https://etc.rivet.link> |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
12-12: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In license.md around line 12, the bare RPC URL "https://etc.rivet.link" should
be formatted as a markdown link or inline code; replace the plain URL with
either a markdown link (e.g., link text pointing to the same URL), or wrap the
URL in backticks or angle brackets so it renders correctly in Markdown.
Zahnentferner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Submitted to the wrong repo. I will close it.
This PR updates the StablePay SDK to support the Ethereum Classic (ETC) Mainnet and renames the existing Ethereum Classic testnet configuration to 'Mordor Testnet' for better clarity and standardization. It addresses Issue #18 by renaming the network and adding a new configuration entry for Ethereum Classic. #17
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.