Skip to content

Conversation

@dark-Invincible
Copy link

@dark-Invincible dark-Invincible commented Dec 14, 2025

This PR updates the StablePay SDK to support the Ethereum Classic (ETC) Mainnet and renames the existing Ethereum Classic testnet configuration to 'Mordor Testnet' for better clarity and standardization. It addresses Issue #18 by renaming the network and adding a new configuration entry for Ethereum Classic. #17

Summary by CodeRabbit

  • New Features

    • Added Ethereum Classic (ETC) Mainnet support to the SDK.
  • Documentation

    • Renamed existing ETC testnet to "Mordor Testnet" for improved clarity.
    • Updated configuration documentation with verified ETC Mainnet contract addresses and RPC endpoint information.

✏️ Tip: You can customize this high-level summary in your review settings.

This PR updates the StablePay SDK to support the Ethereum Classic (ETC) Mainnet and renames the existing Ethereum Classic testnet configuration to 'Mordor Testnet' for better clarity and standardization. It addresses Issue StabilityNexus#18 by renaming the network and adding a new configuration entry for Ethereum Classic.
@coderabbitai
Copy link

coderabbitai bot commented Dec 14, 2025

Walkthrough

StablePay SDK is updated to support Ethereum Classic Mainnet with chain ID 61, associated RPC and contract addresses. The existing ETC testnet configuration is renamed to "Mordor Testnet" for clarity.

Changes

Cohort / File(s) Summary
Network Configuration Updates
license.md
Adds Ethereum Classic Mainnet configuration (chain ID 61, RPC endpoint, Djed Contract address, and ECSD stablecoin address); renames ETC testnet configuration to "Mordor Testnet"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

  • Verify that the Ethereum Classic Mainnet chain ID (61) and RPC endpoint are correct and operational
  • Confirm contract addresses (Djed Contract and ECSD stablecoin) are accurate via provided verification sources (Blockscout, on-chain calls)
  • Ensure testnet rename doesn't break any dependent configurations or documentation

Poem

🐰 Classic Ethereum now hops into place,
Mainnet joins the stable blockchain race,
Mordor stands guard on testnet side,
With verified contracts as our guide,
Config complete, the SDK takes stride! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding Ethereum Classic support to the StablePay SDK, which aligns with the changeset's focus on ETC mainnet configuration and Mordor testnet renaming.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2c3742 and e796cb7.

📒 Files selected for processing (1)
  • license.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
license.md

12-12: Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
license.md (1)

1-16: PR documentation looks comprehensive.

The changes are well-documented with proper verification notes for contract addresses. The Chain ID 61 and RPC endpoint for ETC Mainnet are correctly specified. The rename of the testnet to "Mordor Testnet" provides clarity for standardization.


Chain ID: 61

RPC: https://etc.rivet.link
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Wrap the bare URL in markdown link syntax.

The RPC URL should be formatted as a markdown link or wrapped in backticks/angle brackets to comply with markdown standards.

Apply this diff to fix the markdown formatting:

-RPC: https://etc.rivet.link
+RPC: <https://etc.rivet.link>

Alternatively, use inline code formatting:

-RPC: https://etc.rivet.link
+RPC: `https://etc.rivet.link`
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
RPC: https://etc.rivet.link
RPC: <https://etc.rivet.link>
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

12-12: Bare URL used

(MD034, no-bare-urls)

🤖 Prompt for AI Agents
In license.md around line 12, the bare RPC URL "https://etc.rivet.link" should
be formatted as a markdown link or inline code; replace the plain URL with
either a markdown link (e.g., link text pointing to the same URL), or wrap the
URL in backticks or angle brackets so it renders correctly in Markdown.

Copy link
Contributor

@Zahnentferner Zahnentferner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Submitted to the wrong repo. I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants