Skip to content

Fixed issue#7#15

Open
sarthakNITT wants to merge 10 commits intoSrinjoyeeDey:mainfrom
sarthakNITT:FixedIssue#7
Open

Fixed issue#7#15
sarthakNITT wants to merge 10 commits intoSrinjoyeeDey:mainfrom
sarthakNITT:FixedIssue#7

Conversation

@sarthakNITT
Copy link

solved issue #7

##Summary

Added thunderstorm, rainy, snow, summer, cloud themes.
According to weather[0].main the theme changes.

Proof link - https://drive.google.com/drive/folders/13r2tZsRH4PVXExOCcsUTHawOzpZvvLQh?usp=sharing
In thunderstorm black screen appears, that's not a bug I reloaded the page. Also for the demo purpose I have shown all the animation and themes under cloudy weather. The logic for dynamic theme change according to weather is in components/logic.tsx

@SrinjoyeeDey
Copy link
Owner

Hii @sarthakNITT , this branch has certain conflicts , please resolve them , then I will merge it

@sarthakNITT
Copy link
Author

@SrinjoyeeDey there was no conflicts shown to me. But I have pulled the latest changes from main branch and also updated the .gitignore file. Check it now

@SrinjoyeeDey
Copy link
Owner

SrinjoyeeDey commented Oct 10, 2025

For sunshine can you show the brightness of sun appearing and for snow , snowfall occurring else these two pages are appearing to be static. And all the effects must be present in both modes(light/dark) except for sunshine (which will occur only in light mode )

@sarthakNITT
Copy link
Author

sarthakNITT commented Oct 10, 2025

@SrinjoyeeDey I have made changes. But just one thing that rainy, thunderstorm can only work with dark theme to display those rain drops, storms and snow and summer theme can only look good in light theme because of white snow sun icon. So instead of having dark mode by default I have made it dynamic based on the weather. User can change the theme but lets say in rainy if User change it to light theme then rain won't be visible.

Any suggestions or I should hit a pr? Look at the demo video link given below.
video link - https://drive.google.com/file/d/1ftc93yQGRwzUcjSzbgX-56m4xtRQEb3c/view?usp=sharing

@SrinjoyeeDey
Copy link
Owner

Well my suggestion is to show raining, thunderstorm and snowing in both the modes and sunshine or rain ow only in one . Is it possible?

@SrinjoyeeDey
Copy link
Owner

Instead of using plain white for snow or bright yellow for the sun:

For ❄️ snow, use a cool pastel blue or soft gray tone (e.g., #d0e7ff) as background, with subtle animated snowflakes in slightly darker shades.

For ☀️ sunshine, use a warm gradient — like orange → soft gold → light peach, rather than pure yellow.

💫 Example:

Light Mode → gradient from #a0cfff → #ffffff for snowy

Dark Mode → gradient from #2b5876 → #4e4376 for sunny

This keeps readability and theme balance.

@sarthakNITT
Copy link
Author

@SrinjoyeeDey for snowy I have made this change and for sunny its not only yellow, the colour are changing in gradient. The gradient is of yellow, orange and red. I didn't get that thing in the video but you can check it locally.

And here is the snowy for dark and light theme
Screenshot 2025-10-10 at 6 17 06 PM
Screenshot 2025-10-10 at 6 20 06 PM

And following is the gradients changing from yellow -> orange -> red ....
Screenshot 2025-10-10 at 6 23 18 PM
Screenshot 2025-10-10 at 6 23 24 PM

@SrinjoyeeDey
Copy link
Owner

Hey @sarthakNITT 👋
Thanks for your contribution! I just wanted to highlight something before merging — recently, the weather-dashboard issue was fixed and merged successfully. If I merge your PR right now, it might overwrite those recent changes since your local repo seems to be behind the latest version.

Please pull the latest code from the main branch, update your local repository, and then make the changes again to avoid conflicts.

Also, I noticed that for the cloudy weather condition, the entire screen seems to shake — which can feel a bit confusing for users. It might be better to replace that with a smoother background animation — maybe something like moving dark clouds or a soft overcast effect — to visually represent the cloudy atmosphere without abrupt motion.

Let me know if you can , Once you sync with the latest code and refine this part, it’ll look perfect for merging! 🌤
Also the current changes looks perfect

@SrinjoyeeDey
Copy link
Owner

shake-problem-preview
@sarthakNITT

@sarthakNITT
Copy link
Author

sarthakNITT commented Oct 10, 2025

@SrinjoyeeDey have added the cloud animation background also pulled the latest changes. I have tried merge locally, I'm sure you are ready for merge now.
WhatsApp Image 2025-10-11 at 00 32 22 (1)
WhatsApp Image 2025-10-11 at 00 32 22

@SrinjoyeeDey
Copy link
Owner

Okay I will merge it Tommorow

@SrinjoyeeDey
Copy link
Owner

Yes @sarthakNITT , everything is working fine but I noticed
image
The ui is alot shifted to the edge , which makes some not visible , can you please solve it

@sarthakNITT
Copy link
Author

@SrinjoyeeDey Its not an issue. I've checked it, for reference look at the provided screenshots.

@SrinjoyeeDey
Copy link
Owner

Okayy @sarthakNITT , everything is fine but the latest main contains a music playlist section which is not visible in your PR , it might cause conflict with your dashboard , could you please update your PR to the latest main and then submit . I will merge it then

@sarthakNITT
Copy link
Author

@SrinjoyeeDey check it now. In case of any other latest change. Instead of requesting me again for latest pull, kindly merge main branch with my branch rather than merging my branch with main.
I request to add hacktoberfest-accepted label to this.

Thanks

@SrinjoyeeDey
Copy link
Owner

Hii @sarthakNITT , I know how frustrating it is for you but you must understand my side as well , managing an open source project is a big deal and right now I am handling two projects , a little mistake can cause my entire project to crash and it happened before , so I am more cautious this time .

@SrinjoyeeDey
Copy link
Owner

I would like you to know that open source isn't just about solving a bug or adding feature, it's about collaborating, discussing and improving . Even if it consumes a lot of time . Take that as a advice @sarthakNITT

@sarthakNITT
Copy link
Author

@SrinjoyeeDey I understand your side, maintaining an open source project is a responsibility. But there are multiple changes which happens in a project in a day and it's not possible for a developer to keep pulling the latest commits everytime. Instead it's better to test the pr changes locally and merge the main branch with the developer's branch to keep everything clean. I am sure you have already done that, as this pr is opened from last 2 days. So can we now proceed with the merge now?

@MannuVilasara
Copy link

please consider rebasing your branch instead of merging main into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants