feat: skip generating _ExecutionStub.exe if it already exists #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Mar 18, 2025
There was a problem hiding this comment.
This seems to be entirely whitespace changes, is that intentional?
There was a problem hiding this comment.
Yes, I changed \r to \r\n because it was causing errors on my machine.
The system cannot find the batch label specified - StartDeveloperCommandPrompt.
However, since it works fine on GitHub Actions, I reverted the change.
beyondkmp
added a commit
to electron-userland/electron-builder
that referenced
this pull request
Jul 31, 2025
fix #8952 **Root Cause** when createExecutableStubForExe is executed, WriteZipToSetup writes information to the file, essentially creating a new file, which invalidates the original signature.  https://github.com/Squirrel/Squirrel.Windows/blob/51f5e2cb01add79280a53d51e8d0cfa20f8c9f9f/src/Update/Program.cs#L633-L647  **How to fix** Apply a patch to the Squirrel Windows source code(Squirrel/Squirrel.Windows#1903). For the existing stub exe files, don't generate them anymore. Then, a new stub exe can be generated in Electron Builder and signed. --------- Co-authored-by: Mike Maietta <[email protected]>
daihere1993
pushed a commit
to daihere1993/electron-builder
that referenced
this pull request
Jul 31, 2025
fix electron-userland#8952 **Root Cause** when createExecutableStubForExe is executed, WriteZipToSetup writes information to the file, essentially creating a new file, which invalidates the original signature.  https://github.com/Squirrel/Squirrel.Windows/blob/51f5e2cb01add79280a53d51e8d0cfa20f8c9f9f/src/Update/Program.cs#L633-L647  **How to fix** Apply a patch to the Squirrel Windows source code(Squirrel/Squirrel.Windows#1903). For the existing stub exe files, don't generate them anymore. Then, a new stub exe can be generated in Electron Builder and signed. --------- Co-authored-by: Mike Maietta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When _ExecutionStub.exe already exists in the files, avoid overwriting it. This is primarily because during the build process, _ExecutionStub.exe is automatically generated with my custom complex signatures process(Information is written to _ExecutionStub.exe through WriteZipToSetup, which only adds custom complex signatures), but Squirrel Windows overwrites it, causing the loss of signatures.