Synchronous code signing #1278
Open
Synchronous code signing #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs another small adjustment first |
|
Just push more commits, you don't need to close this PR |
|
Also, you can really just set the concurrency factor of ForEachAsync to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching the Releasify method to code sign files in a synchronous method (as opposed to async). For larger projects, with more than 130 signable files, the async handling of this causes lots of deadlocks and freezes in our docker build image.
This simplified, synchronous version works awesome, has no freezes or deadlocks, and in our testing (with lots of signable files) actually completes faster than the previous async version. Go figure. =)