-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Apple Home Screen Shortcut Metadata #106
Conversation
While signing up for the event, I noticed that the app didn't have an icon/preset name when adding it to my home screen for visiting it again later. I looked through the source to see if I could find the original SVG of the icon, but it doesn't seem to be in the repo. This could be a placeholder until it's possible to do a proper export of that at 180x180, since I simply just re-scaled down the 512x512 favicon bilinearly.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CI failures are unrelated. I'll fix them. Pardon our dust... 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
original SVG of the icon
Yeah, just a screenshot we took of the site once 😄. There's no SVG. That could be a good followup!
@all-contributors please add @Offroaders123 for code.
|
I've put up a pull request to add @Offroaders123! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
Adds @Offroaders123 as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#106 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
While signing up for the event, I noticed that the app didn't have an icon/preset name when adding it to my home screen for visiting it again later.
I looked through the source to see if I could find the original SVG of the icon, but it doesn't seem to be in the repo. This could be a placeholder until it's possible to do a proper export of that at 180x180, since I simply just re-scaled down the 512x512 favicon bilinearly.
PR Checklist
status: accepting prs
Overview
This commit adds the missing icon and site name metadata, improving the user experience of bookmarking the site to your Home Screen 😊