Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Apple Home Screen Shortcut Metadata #106

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Offroaders123
Copy link
Contributor

While signing up for the event, I noticed that the app didn't have an icon/preset name when adding it to my home screen for visiting it again later.

I looked through the source to see if I could find the original SVG of the icon, but it doesn't seem to be in the repo. This could be a placeholder until it's possible to do a proper export of that at 180x180, since I simply just re-scaled down the 512x512 favicon bilinearly.

PR Checklist

Overview

This commit adds the missing icon and site name metadata, improving the user experience of bookmarking the site to your Home Screen 😊

While signing up for the event, I noticed that the app didn't have an icon/preset name when adding it to my home screen for visiting it again later.

I looked through the source to see if I could find the original SVG of the icon, but it doesn't seem to be in the repo. This could be a placeholder until it's possible to do a proper export of that at 180x180, since I simply just re-scaled down the 512x512 favicon bilinearly.
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
squiggle-conf ✅ Ready (Inspect) Visit Preview 1 resolved Aug 23, 2024 9:00pm

@JoshuaKGoldberg JoshuaKGoldberg changed the title Apple Home Screen Shortcut Metadata feat: add Apple Home Screen Shortcut Metadata Aug 23, 2024
@JoshuaKGoldberg
Copy link
Member

CI failures are unrelated. I'll fix them. Pardon our dust... 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original SVG of the icon

Yeah, just a screenshot we took of the site once 😄. There's no SVG. That could be a good followup!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 228a0f7 into SquiggleTools:main Aug 23, 2024
9 of 10 checks passed
@JoshuaKGoldberg
Copy link
Member

@all-contributors please add @Offroaders123 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @Offroaders123! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this pull request Aug 23, 2024
Adds @Offroaders123 as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#106 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Apple Home Screen Shortcut Metadata
2 participants