Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that ModifyArgs.index is the absolute index, not relative #666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify that ModifyArgs.index is the absolute index, not relative #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/main/java/org/spongepowered/asm/mixin/injection/ModifyArg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,13 @@
public At at();

/**
* <p>Gets the argument index on the target to set. It is not necessary to
* set this value if there is only one argument of the modifier type in the
* hooked method's signature. For example if the target method accepts a
* boolean, an integer and a String, and the modifier method accepts and
* returns an integer, then the integer parameter will be automatically
* selected.</p>
* <p>The zero-based, absolute index of the argument to set on the target.</p>
*
* <p>The index is zero-based.</p>
* <p>It is not necessary to set this value if there is only one argument of
* the modifier type in the hooked method's signature. For example if the target
* method accepts a boolean, an integer and a String, and the modifier method
* accepts and returns an integer, then the integer parameter will be automatically
* selected.</p>
*
* @return argument index to modify or -1 for automatic
*/
Expand Down