Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use wrapper tasks, fix #357 #384

Closed
wants to merge 3 commits into from
Closed

Conversation

NikkyAI
Copy link
Collaborator

@NikkyAI NikkyAI commented Jul 2, 2021

🚀 Description

removed gradlew/gradle symlinks from sample projects
instead added the wrapper task

changed CI to always use the wrappers in plugins/

idea will automatically create the gradlew file and gradle/ folders when linking the gradle projects
and also add it to .git/info/exclude (local gitignore) so it will nto commit duplicates
... at least on my systems

📄 Motivation and Context

fixes #357
symlinks end up as plain files on windows,making it impossible to develop without replacing the symlinks with real files, which messes with git diffs

🧪 How Has This Been Tested?

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Sorry, something went wrong.

@LouisCAD
Copy link
Member

LouisCAD commented Jul 2, 2021

Can you undo the changes to the versions.properties files? They are unrelated to the change and make review and history complicated.

@NikkyAI
Copy link
Collaborator Author

NikkyAI commented Jul 2, 2021

i did not even realize i comitted them accidentally

@LouisCAD
Copy link
Member

LouisCAD commented Jul 3, 2021

Using the commit tool window in IntelliJ can help to check what is included in the impeding commit, and uncheck changes or files.

@jmfayard
Copy link
Member

idea will automatically create the gradlew file and gradle/ folders when linking the gradle projects
and also add it to .git/info/exclude (local gitignore) so it will nto commit duplicates

That part doesn't work to me. How is that supposed to work?

@jmfayard
Copy link
Member

jmfayard commented Sep 5, 2022

Thanks for your work, unfortunately I never got it to work, I guess we can suffer having dupes of those gradle files

@jmfayard jmfayard closed this Sep 5, 2022
@LouisCAD LouisCAD self-assigned this Sep 14, 2022
@LouisCAD
Copy link
Member

@jmfayard Did you try this PR, it did you try something else?

@jmfayard
Copy link
Member

now replaced with #626

@jmfayard jmfayard closed this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace duplicated gradle wrappers by symlink and add samples CI check for 6.3+
3 participants