Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Grammar fixes#49

Open
J-128 wants to merge 23 commits intoSpirtix:masterfrom
J-128:grammar-fixes
Open

Grammar fixes#49
J-128 wants to merge 23 commits intoSpirtix:masterfrom
J-128:grammar-fixes

Conversation

@J-128
Copy link
Contributor

@J-128 J-128 commented Oct 31, 2023

This branch can wait to be merged. I'm sure there are several other missiontexts with incorrect grammar, so instead of creating a branch and opening a pull request for each, we can collect all the fixes in this branch, and merge it once they're commited.

Context: Harald: "Regardless: I know Snoggletog is important to Berkians. Stormheart and I have a proposition for you, in the spirit of the holidays. I only hope that you can approach it with the same courtesy."
@J-128
Copy link
Contributor Author

J-128 commented Oct 31, 2023

If you want to help, you can open pull requests to my grammar-fixes branch, and I can check, merge, and commit them there.

@Spirtix Spirtix force-pushed the master branch 2 times, most recently from d814ce2 to 6bc5a0b Compare December 2, 2023 16:26
Spirtix and others added 22 commits December 7, 2023 20:38
- CreateRaisedPet endpoint
- support for 1.6 apiKey + util class for management apiKey version recognition
- add fake missions for unlock fishing and mythie grow up
- add games to store
Context: Harald: "Regardless: I know Snoggletog is important to Berkians. Stormheart and I have a proposition for you, in the spirit of the holidays. I only hope that you can approach it with the same courtesy."
context: Dagur: "We were out searching for Skrills to join the Berserkers when we came across her. We think she was trying to become friends with a Skrill at Glacier Island, but the Skrill was having none of it. No fault of our mystery dragon; Skrills just are very territorial!"
Context: <Text>Work with your dragon to collect 15 flowers</Text>
* fix: jobs disappear after completing
* fix: jobs (and quest) does not cost items
we use ascii/utf-8 (not utf-16) encoding in files and network data
so XML header should be always `<?xml version="1.0" encoding="utf-8"?>`
Context: Harald: "Regardless: I know Snoggletog is important to Berkians. Stormheart and I have a proposition for you, in the spirit of the holidays. I only hope that you can approach it with the same courtesy."
context: Dagur: "We were out searching for Skrills to join the Berserkers when we came across her. We think she was trying to become friends with a Skrill at Glacier Island, but the Skrill was having none of it. No fault of our mystery dragon; Skrills just are very territorial!"
Context: &lt;Text>Work with your dragon to collect 15 flowers&lt;/Text>
Context: Ruffnut: "You just picked a random island, didn't you?"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants