Windows port #4
Open
Windows port #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totally unchecked, except for checking that $app and $username works for both Windows and Linux.
…pp' target does. This helps Windows users who don't have to install make, but it should work for Linux as well. The next commit will implement the 'install-defaults' functionality.
2. Sanitize slicer path so that giving a full path in --slicer doesn't affect slicer checks (both optional .exe suffix and case differences) 3. Report sanitized slicer type if verbose flag is on.
Removed option for user level install.
|
Looking forward to this merge since I don't have/use Linux :-) |
|
@ETE-Design have you tried this branch, is it working for you? |
|
@udif Not yet, still working on an Prototype of an Non-Planar hotend, so hope this will be merged before I'm ready... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a Windows port of the script. The original version had a few issues:
basename()andcatfile().README.mdwith a Windows section, including the specific filenames to be used for the various slicer options.I was careful, and I hope I didn't break the Linux version, but I haven't ran all checks on the Linux side because I don't have all the slicers installed on my machine.
I also added an
--installflag which helps Windows users by not needing to installmakejust for installation. It should also work on Linux using the existing paths (~/.configand/usr/share).