Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji cloud #357

Merged
merged 9 commits into from
Jan 14, 2025
Merged

Add emoji cloud #357

merged 9 commits into from
Jan 14, 2025

Conversation

Adrian-Thiesen
Copy link
Collaborator

Added a cloud and also adjusted some regex

Copy link

github-actions bot commented Jan 16, 2024

Visit the preview URL for this PR (updated for commit 2a4074e):

https://whatsanalyze-80665--pr357-add-emoji-cloud-els009h8.web.app

(expires Tue, 21 Jan 2025 15:19:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5796a863d3a1b99df3fcb31feec7a39514d97aa4

Copy link

gitguardian bot commented Jan 10, 2025

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14799759 Triggered Generic Private Key fc97f8d localhost-key.pem View secret
14817188 Triggered Generic High Entropy Secret 765ddf6 functions/backendClientRegistry.js View secret
14799760 Triggered Generic Private Key fc97f8d 0.0.0.0.key View secret
14818802 Triggered Generic High Entropy Secret 765ddf6 components/SubscribeBtn.vue View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

athi added 4 commits January 10, 2025 12:40
…ot all emojis are considered and the word cloud looks bad if set high it looks good but it seems performance might be bad. I also don't get why the number needs to be high since emojis are limited anyhow.
@Adrian-Thiesen Adrian-Thiesen merged commit 937cc8a into dev Jan 14, 2025
2 of 3 checks passed
@Adrian-Thiesen Adrian-Thiesen deleted the add_emoji_cloud branch January 14, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants