linkedin#52

SparshithNR · SparshithNR · commit 8398fff91f3d · 2017-06-27T10:53:52.000-07:00
linkedin#52: Changed accuracy to be +-16ms*skip_cycle
diff --git a/test/headless/specs/watcher/impression-complete-event.spec.js b/test/headless/specs/watcher/impression-complete-event.spec.js
@@ -67,7 +67,7 @@ testModule('Impression Complete event', class extends WatcherTestClass {
       .scrollTo(0)
       .wait(RAF_THRESHOLD * SKIP_CYCLE)
       .assert(function(e) {
-        return e.meta.duration >= ((IMPRESSION_THRESHOLD * 5) - (RAF_THRESHOLD * SKIP_CYCLE)) && e.meta.duration <= ((IMPRESSION_THRESHOLD * 5)  (RAF_THRESHOLD * SKIP_CYCLE)) && e.id === 5 && e.e === 'impression-complete';
+        return e.meta.duration >= ((IMPRESSION_THRESHOLD * 5) - (RAF_THRESHOLD * SKIP_CYCLE)) && e.meta.duration <= ((IMPRESSION_THRESHOLD * 5) + (RAF_THRESHOLD * SKIP_CYCLE)) && e.id === 5 && e.e === 'impression-complete';
       }, 1)
       .done();
   }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ testModule('Impression Complete event', class extends WatcherTestClass {`
`67`	`67`	`.scrollTo(0)`
`68`	`68`	`.wait(RAF_THRESHOLD * SKIP_CYCLE)`
`69`	`69`	`.assert(function(e) {`
`70`		`- return e.meta.duration >= ((IMPRESSION_THRESHOLD * 5) - (RAF_THRESHOLD * SKIP_CYCLE)) && e.meta.duration <= ((IMPRESSION_THRESHOLD * 5) (RAF_THRESHOLD * SKIP_CYCLE)) && e.id === 5 && e.e === 'impression-complete';`
	`70`	`+ return e.meta.duration >= ((IMPRESSION_THRESHOLD * 5) - (RAF_THRESHOLD * SKIP_CYCLE)) && e.meta.duration <= ((IMPRESSION_THRESHOLD * 5) + (RAF_THRESHOLD * SKIP_CYCLE)) && e.id === 5 && e.e === 'impression-complete';`
`71`	`71`	`}, 1)`
`72`	`72`	`.done();`
`73`	`73`	`}`