Skip to content

Commit f8a5b33

Browse files
committed
linkedin#52: Changed accuracy to be +-16ms*skip_cycle
1 parent b9ed1d5 commit f8a5b33

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

test/headless/specs/spaniel-observer.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ testModule('SpanielObserver', class extends SpanielObserverTestClass {
6464
.evaluate(function() {
6565
window.observer.unobserve(window.target);
6666
})
67-
.wait(20)
67+
.wait(100)
6868
.getExecution()
6969
.evaluate(function() {
7070
return window.STATE.impressions === 1 && window.STATE.completes === 1;

test/headless/specs/watcher/impression-complete-event.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ testModule('Impression Complete event', class extends WatcherTestClass {
6767
.scrollTo(0)
6868
.wait(RAF_THRESHOLD * SKIP_CYCLE)
6969
.assert(function(e) {
70-
return e.meta.duration >= 495 && e.meta.duration <= 545 && e.id === 5 && e.e === 'impression-complete';
70+
return e.meta.duration >= ((IMPRESSION_THRESHOLD * 5) - (RAF_THRESHOLD * SKIP_CYCLE)) && e.meta.duration <= ((IMPRESSION_THRESHOLD * 5) (RAF_THRESHOLD * SKIP_CYCLE)) && e.id === 5 && e.e === 'impression-complete';
7171
}, 1)
7272
.done();
7373
}

test/headless/specs/watcher/impression-event.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const { time: { IMPRESSION_THRESHOLD, RAF_THRESHOLD, SMALL }, ITEM_TO_OBSERVE, S
1717
testModule('Impression event', class extends WatcherTestClass {
1818
['@test should not fire if item is exposed but not impressed']() {
1919
return this.context.scrollTo(50)
20-
.wait(RAF_THRESHOLD * 2)
20+
.wait(RAF_THRESHOLD * SKIP_CYCLE)
2121
.assertOnce(ITEM_TO_OBSERVE, 'exposed')
2222
.assertNever(ITEM_TO_OBSERVE, 'impressed')
2323
.assertOnce(ITEM_TO_OBSERVE, 'exposed')

0 commit comments

Comments
 (0)