Configure CI on self-hosted runner #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenbunu
commented
May 4, 2025
•
sevenbunu
commented
- Update build pipeline for GitHub-hosted runner (choose the oldest possible versions of ubuntu, cuda, gcc to maintain backward compatibility with new versions)
- Add build and test pipeline for GPU use case of library
- Update install script for cuda-12.8 on Ubuntu-24.04
- Work is based on Updated supported CUDA verison to 12.8 #16, so all changes that aren't connected with points above are made by @mitya-y
sevenbunu
force-pushed
the
self-hosted-runner
branch
from
4695301 to
033366a
Compare
vkutuev
requested changes
May 14, 2025
| - name: Run unit-tests | ||
| working-directory: ${{ env.build_dir }} | ||
| run: | | ||
| source scripts/run_tests_all.sh | tee ${{ env.unit-test-file }} |
Comment on lines
+80
to
+82
| if grep -q "FAILED" ${{ env.unit-test-file }}; then | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if grep -q "FAILED" ${{ env.unit-test-file }}; then | |
| exit 1 | |
| fi | |
| ! grep -q "FAILED" ${{ env.unit-test-file }} |
| - name: Run regression-tests | ||
| working-directory: ${{ env.build_dir }}/python | ||
| run: | | ||
| source run_tests.sh 2>&1 | tee ${{ env.regression-test-file }} |
Comment on lines
+98
to
+100
| if grep -q "FAILED" ${{ env.regression-test-file }}; then | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if grep -q "FAILED" ${{ env.regression-test-file }}; then | |
| exit 1 | |
| fi | |
| ! grep -q "FAILED" ${{ env.regression-test-file }} |
Comment on lines
+47
to
+49
| working-directory: ${{ env.build_dir }} | ||
| run: | | ||
| cmake --build . --target all --verbose -j `nproc` |
There was a problem hiding this comment.
Suggested change
| working-directory: ${{ env.build_dir }} | |
| run: | | |
| cmake --build . --target all --verbose -j `nproc` | |
| run: | | |
| cmake --build ${{ env.build_dir }} --target all --verbose -j `nproc` |
Comment on lines
+88
to
+90
| if grep -q "FAILED" ${{ env.unit-test-file }}; then | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if grep -q "FAILED" ${{ env.unit-test-file }}; then | |
| exit 1 | |
| fi | |
| ! grep -q "FAILED" ${{ env.unit-test-file }} |
Comment on lines
+106
to
+108
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if grep -q "FAILED" ${{ env.regression-test-file }}; then | |
| exit 1 | |
| fi | |
| ! grep -q "FAILED" ${{ env.regression-test-file }} |
Comment on lines
+929
to
+951
| * Performs result = left * ~right, where | ||
| * '*' is boolean semiring 'and' operation | ||
| * '~' is operation for invert matrix (0 swaps to 1 and 1 to 0) | ||
| * | ||
| * @note To perform this operation matrices must be compatible | ||
| * dim(left) = M x T | ||
| * dim(right) = T x N | ||
| * dim(result) = M x N | ||
| * | ||
| * @note Pass `CUBOOL_HINT_TIME_CHECK` hint to measure operation time | ||
| * | ||
| * @param result[out] Destination matrix to store result | ||
| * @param left Source matrix to be multiplied | ||
| * @param right Source matrix to be inverted and multiplied | ||
| * @param hints Hints for the operation | ||
| * | ||
| * @return Error code on this operation | ||
| */ | ||
| CUBOOL_EXPORT CUBOOL_API cuBool_Status cuBool_Matrix_EWiseMulInverted( | ||
| cuBool_Matrix result, | ||
| cuBool_Matrix matrix, | ||
| cuBool_Matrix mask, | ||
| cuBool_Hints hints |
There was a problem hiding this comment.
The names of the function parameters don't match the names in docs
| @@ -1,8 +1,12 @@ | |||
| # Original script from https://github.com/ptheywood/cuda-cmake-github-actions | |||
There was a problem hiding this comment.
Please verify script with shellcheck (there are a lot of warnings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.