Skip to content

Fix worksheetTitle values in set-requires-testing-status.yml#11

Open
nlon982 wants to merge 2 commits intomainfrom
nlon982-fix-set-requires-testing-status-update-worksheet-and-improve-read-worksheet
Open

Fix worksheetTitle values in set-requires-testing-status.yml#11
nlon982 wants to merge 2 commits intomainfrom
nlon982-fix-set-requires-testing-status-update-worksheet-and-improve-read-worksheet

Conversation

@nlon982
Copy link

@nlon982 nlon982 commented Jun 28, 2023

  1. Fix update_worksheet's worksheetTitle variable

    This is a random guess at what caused the issue Hugh described:

    read_worksheet was successful
    update_worksheet used the wrong worksheetTitle (it uses the first worksheet, rather than "Dev QA")

  2. Change to make read_worksheet's worksheetTitle not hardcoded.


Testing to make sure nothing has been broken:
Merge in a content-hub PR and check its status in "Dev QA" is updated to "REQUIRES TESTING"

@nlon982 nlon982 changed the title Fix update_worksheet worksheetTitle variable, and make read_worksheet's 's worksheetTitle not hardcoded Fix update_worksheet's worksheetTitle variable, and make read_worksheet's worksheetTitle value not hardcoded Jun 28, 2023
@HughParsons HughParsons requested a review from Prendo93 June 28, 2023 22:12
@nlon982
Copy link
Author

nlon982 commented Jun 28, 2023

Note, one place this is called is content-hub. I used this when considering the changes:
https://github.com/SpalkLtd/content-hub/blob/master/.github/workflows/set-req-testing-status.yml

@nlon982 nlon982 changed the title Fix update_worksheet's worksheetTitle variable, and make read_worksheet's worksheetTitle value not hardcoded Fix worksheetTitle values in set-requires-testing-status.yml Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant