Implement telemetry memory #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 81.98% 83.52% +1.53%
==========================================
Files 49 54 +5
Lines 1782 1948 +166
Branches 77 78 +1
==========================================
+ Hits 1461 1627 +166
Misses 321 321 ☔ View full report in Codecov by Sentry. |
This is necessary for deserialization.
PatrickKa
force-pushed
the
implement-telemetry-memory
branch
from
88e4db5 to
abe7b38
Compare
The `TelemetryRecord` contains all the beacon data according to the spreadsheet on the nextcloud.
For some reason generating the coverage report yields a negative count somewhere in `PersistentVariables.ipp`. I don't know why this happens. Compiling with `-fprofile-update=atomic` as suggested by the error message doesn't help. It only makes the SPI supervisor test require ~100 bytes more stack without getting rid of the error. Therefore, I followed the second suggestion and changed the coverage command to ignore such negative counts.
Also, add a test section that ensures that all booleans are serialized and deserialized correctly.
PatrickKa
force-pushed
the
implement-telemetry-memory
branch
from
abe7b38 to
e97f433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new
Telemetrycomponent withTelemetryRecord, a struct holding the telemetry variablestelemetryMemory, anFramRingArrayofTelemetryRecordsAlso, move all EDU structs and enums to
Types.hpp/ipp.Fixes #179
Fixes parts of #198