Fix failing device ID and flash tests #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, semaphores don't yet work correclty in a thread's `init()` function. Since `HardwareSpi::DoInitialize()` uses one, we must not initialize SPIs there. Of course, this extends to all peripherals that use an SPI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 49 49
Lines 1782 1782
Branches 77 77
=======================================
Hits 1461 1461
Misses 321 321 ☔ View full report in Codecov by Sentry. |
We use the explicit 4-byte address commands anyway so it makes no difference which mode we are in. Interestingly, status register 3 now reads 0x41 instead 0x40. According to the datasheet this would mean that we are now in 4-byte mode and previously were in 3-byte mode. This is weird and unexpected but errors in datasheets are not unheard of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
Fixes #340