Update docker image, reduce binary sizes, and fix tests #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 1.11.0 the Docker images are based on Ubuntu 24.04, which uses GCC 13 by default. For some reason the standard c++ library that comes with it causes clang-tidy to throw errors about some operator delete not being defined. As it turns out the errors are about the sized operator delete that has been introduced already in C++14, so I really don't know why clang only complains about it now.
In the Docker image version 1.11.0, the toolchain file was updated and already sets our desired flags for the usual configurations (Debug, Release, RelWithDebInfo, MinSizeRel).
I renamed the header file and macro for enabling `DEBUG_PRINT` to something more specific.
The HW test was missing the initial sleep to wait for all startup tests to be over. For this I had to make the startup test timeout constants public.
Also, add `AllChecksPassed()` to HW test utilities.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 79.34% 79.68% +0.34%
==========================================
Files 47 47
Lines 1578 1580 +2
Branches 57 57
==========================================
+ Hits 1252 1259 +7
+ Misses 326 321 -5 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Docker image is what allows us to significantly reduce the binary sizes and use the right flags for the four typical configurations by default. There were also some tests that no longer compiled, ran, or were otherwise not correct. I fixed those.
Fixes #332