Skip to content

fix: resolve all CI build errors and lint warnings (issue #384) - #385

Open
damiedee96 wants to merge 1 commit into
Space-Nebula:mainfrom
damiedee96:fix/issue-384-ci-build-errors
Open

fix: resolve all CI build errors and lint warnings (issue #384)#385
damiedee96 wants to merge 1 commit into
Space-Nebula:mainfrom
damiedee96:fix/issue-384-ci-build-errors

Conversation

@damiedee96

Copy link
Copy Markdown

closes #384

  • Remove #![no_std] at module level in resource_minter.rs
  • Remove PartialOrd/Ord derives from #[contracterror] enums (MinterError, GovError)
  • Fix symbol_short! strings exceeding 9-char limit in metrics_exporter, migration_framework, cache_ttl_manager
  • Add BytesN to migration_framework imports; remove duplicate use at end of file
  • Change Vec to Bytes in CachedData contracttype struct (u8 not TryFromVal compatible)
  • Fix &&Address double-reference in metrics_exporter event publish
  • Remove unused imports: Map, Vec, BytesN, String, Symbol, Address, Bytes across 20+ files
  • Remove unused storage::Instance import from access_control.rs
  • Remove unused mut keywords: cleared (cache_ttl_manager), proposal_id (governance), queue (pvp_combat x2)
  • Fix borrow-after-move: namespace in cache_ttl_manager, storage_uri in state_snapshot
  • Prefix unused local variables with underscore: _record, _backup, _boosted_qty
  • Fix creator_contents mut in delete_content (read-only path)

closes #384

…a#384)

- Remove #![no_std] at module level in resource_minter.rs
- Remove PartialOrd/Ord derives from #[contracterror] enums (MinterError, GovError)
- Fix symbol_short! strings exceeding 9-char limit in metrics_exporter, migration_framework, cache_ttl_manager
- Add BytesN to migration_framework imports; remove duplicate use at end of file
- Change Vec<u8> to Bytes in CachedData contracttype struct (u8 not TryFromVal compatible)
- Fix &&Address double-reference in metrics_exporter event publish
- Remove unused imports: Map, Vec, BytesN, String, Symbol, Address, Bytes across 20+ files
- Remove unused storage::Instance import from access_control.rs
- Remove unused mut keywords: cleared (cache_ttl_manager), proposal_id (governance), queue (pvp_combat x2)
- Fix borrow-after-move: namespace in cache_ttl_manager, storage_uri in state_snapshot
- Prefix unused local variables with underscore: _record, _backup, _boosted_qty
- Fix creator_contents mut in delete_content (read-only path)
@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@damiedee96 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix falling Cli Checks

1 participant