fix: resolve all CI build errors and lint warnings (issue #384) - #385
Open
damiedee96 wants to merge 1 commit into
Open
fix: resolve all CI build errors and lint warnings (issue #384)#385damiedee96 wants to merge 1 commit into
damiedee96 wants to merge 1 commit into
Conversation
…a#384) - Remove #![no_std] at module level in resource_minter.rs - Remove PartialOrd/Ord derives from #[contracterror] enums (MinterError, GovError) - Fix symbol_short! strings exceeding 9-char limit in metrics_exporter, migration_framework, cache_ttl_manager - Add BytesN to migration_framework imports; remove duplicate use at end of file - Change Vec<u8> to Bytes in CachedData contracttype struct (u8 not TryFromVal compatible) - Fix &&Address double-reference in metrics_exporter event publish - Remove unused imports: Map, Vec, BytesN, String, Symbol, Address, Bytes across 20+ files - Remove unused storage::Instance import from access_control.rs - Remove unused mut keywords: cleared (cache_ttl_manager), proposal_id (governance), queue (pvp_combat x2) - Fix borrow-after-move: namespace in cache_ttl_manager, storage_uri in state_snapshot - Prefix unused local variables with underscore: _record, _backup, _boosted_qty - Fix creator_contents mut in delete_content (read-only path)
|
@damiedee96 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #384
closes #384