fix golangci-lint config files #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I had to rename and edit the golang-ci-lint config files in ex-1-local-env and ex-2-channels-routines/solution.
I use golangci-lint version 1.50.1.
According to https://golangci-lint.run/usage/configuration/ the config files should be named .golangci.yml.
Also I removed some run options in the config files because I think the defaults are fine here.
More important I fixed the indentation for linters:.
I had to edit the ex-1-local-env/README.md as well:
- I changed name of the config file, links, and typos.
- More important the shell command to run individual linters did not work for me so I changed it.
BTW the Vim image and the dotfile vimrc has a typo: should be ineffassign not ifeffassign.
Best regards,
Kai-Uwe