Skip to content

Conversation

toothstone
Copy link

To keep the image up to date this adds running the workflow on pushes to main. I've added the more commonly used tag latest, main is kept for comparability.

To allow for downgrades/version pinning where desired, this adds tagged images using the short commit SHA.

@mbuechse
Copy link
Contributor

This has been taken offline on purpose, because we no longer use the images.
See bb74a7c

@toothstone
Copy link
Author

Well I'm interested in using it ;) The current image with the tag "main" is completely outdated, I think it should either be ensured it is up to date, or removed.

Also, since the container-based workflow is part of the Tests documentation (and thus officially supported?!), I think the Dockerfile should at least get the most basic test coverage of "does it even build".

#931 seems to imply there might be some other registry from which I can get an official image?

@mbuechse
Copy link
Contributor

mbuechse commented Sep 12, 2025

The recommended way is to not use Docker, but you're right: so long as we offer a Dockerfile, we should include it into CI tests. That doesn't mean, however, that we upload the image to a registry. We should remove the outdated images. Off the top of my head, I don't know how to do that.

@toothstone
Copy link
Author

I'm probably missing some of the history here, but I don't get why SCS maintains a Dockerfile that is not meant to be used. The README says nothing about a preferred way to run the tests, and I can't see any technical reason either. This has worked fine for me so far.
If there is a Dockerfile, somebody (probably me) will put an image on a public registry. I think it would be better if that image were to stay under SCS' control.

@fkr
Copy link
Member

fkr commented Sep 12, 2025

The recommended way is to not use Docker, but you're right: so long as we offer a Dockerfile, we should include it into CI tests. That doesn't mean, however, that we upload the image to a registry. We should remove the outdated images. Off the top of my head, I don't know how to do that.

I'll remove the outdated ones.

I do think having one image of the latest main would be nice.

@fkr
Copy link
Member

fkr commented Sep 12, 2025

The recommended way is to not use Docker, but you're right: so long as we offer a Dockerfile, we should include it into CI tests. That doesn't mean, however, that we upload the image to a registry. We should remove the outdated images. Off the top of my head, I don't know how to do that.

I'll remove the outdated ones.

done.
One needs to stay. which imho speaks even more for having a job that uploads the latest / greatest.

@fkr
Copy link
Member

fkr commented Sep 12, 2025

fwiw: https://github.com/rajatjindal/ghcr-cleanup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants