-
Notifications
You must be signed in to change notification settings - Fork 27
Publish up-to-date image for compliance checks #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This has been taken offline on purpose, because we no longer use the images. |
Well I'm interested in using it ;) The current image with the tag "main" is completely outdated, I think it should either be ensured it is up to date, or removed. Also, since the container-based workflow is part of the Tests documentation (and thus officially supported?!), I think the Dockerfile should at least get the most basic test coverage of "does it even build". #931 seems to imply there might be some other registry from which I can get an official image? |
The recommended way is to not use Docker, but you're right: so long as we offer a Dockerfile, we should include it into CI tests. That doesn't mean, however, that we upload the image to a registry. We should remove the outdated images. Off the top of my head, I don't know how to do that. |
I'm probably missing some of the history here, but I don't get why SCS maintains a Dockerfile that is not meant to be used. The README says nothing about a preferred way to run the tests, and I can't see any technical reason either. This has worked fine for me so far. |
I'll remove the outdated ones. I do think having one image of the latest main would be nice. |
done. |
To keep the image up to date this adds running the workflow on pushes to main. I've added the more commonly used tag
latest
,main
is kept for comparability.To allow for downgrades/version pinning where desired, this adds tagged images using the short commit SHA.