Add larger memory flavors #938
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| Generate flavor specification file for osism's flavor manager, | ||
| cf. https://github.com/osism/openstack-flavor-manager . | ||
|
|
||
| The spec file is output to stdout. | ||
| """ | ||
| import logging | ||
| import sys | ||
|
|
||
| import yaml | ||
|
|
||
| from scs_0100_flavor_naming.flavor_names import compute_flavor_spec | ||
| from scs_0103_standard_flavors.standard_flavors import \ | ||
| SCS_0103_V1_MANDATORY, SCS_0103_V1_RECOMMENDED | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def convert_flavor_spec(canonical_name, spec): | ||
| """convert `spec` into format for openstack-flavor-manager""" | ||
| converted = { | ||
| 'name': canonical_name, | ||
| 'cpus': spec['cpus'], | ||
| 'ram': int(1024 * spec['ram']), | ||
| } | ||
| if 'disk' in spec: | ||
| converted['disk'] = spec['disk'] | ||
| for k, v in spec.items(): | ||
| if not k.startswith('scs:'): | ||
| continue | ||
| converted[k] = v | ||
| return converted | ||
|
|
||
|
|
||
| def compute_spec_list(canonical_names): | ||
| return [ | ||
| convert_flavor_spec( | ||
| canonical_name, | ||
| compute_flavor_spec(canonical_name), | ||
| ) | ||
| for canonical_name in canonical_names | ||
| ] | ||
|
|
||
|
|
||
| def main(argv): | ||
| logging.basicConfig(format='%(levelname)s: %(message)s', level=logging.INFO) | ||
|
|
||
| # boilerplate / scaffolding | ||
| result = yaml.safe_load(""" | ||
| reference: | ||
| - field: name | ||
| mandatory_prefix: SCS- | ||
| - field: public | ||
| default: true | ||
| - field: disabled | ||
| default: false | ||
| - field: cpus | ||
| - field: ram | ||
| - field: disk | ||
| mandatory: [] | ||
| recommended: [] | ||
| """) | ||
|
|
||
| result['mandatory'] = compute_spec_list(SCS_0103_V1_MANDATORY) | ||
| result['recommended'] = compute_spec_list(SCS_0103_V1_RECOMMENDED) | ||
|
|
||
| print(yaml.dump(result, sort_keys=False)) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main(sys.argv[1:])) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest NOT to recommend flavors with root disks any more unless those are local SSDs.
We can add a reminder that we do recommend to use 5, 10, 20, 50, 100, 200, 500, 1000 as disk sizes (and scale them with RAM) in case providers feel a need to have flavors with disks.
(The flavors with 64GiB RAM could have a 200GB disk and 128GiB a 500G disk in my world, but again, let's rather not recommend them at all.)