Skip to content

Conversation

jschoone
Copy link
Contributor

… 1.32.5

What this PR does / why we need it:

New versions.
YAML files were ordered by the generate script.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@jschoone jschoone requested a review from garloff May 28, 2025 20:10
name: openstack
cloudName: openstack
name: ubuntu-capi-image-v1.32.5
openstack_loadbalancer_apiserver: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the default to not have a LB in front of the kubernetes-apiserver. Why?
(Since I switched all my defaults to octavia-ovn, I have started to consider LBs as cheap and reliable resource ...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still deeply confused to see these tarballs in the git repo.

  • Are they even used in any way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically they must not be in the git repo but in the cluster stack release because CSO can not download them.
So we can add them to gitignore, but then csctl won't work ootb, the helm dependencies must be build before.
I think it would be a good idea to consider SovereignCloudStack/cluster-stack-operator#277

@garloff
Copy link
Member

garloff commented Jun 5, 2025

Trying to support both old-style cloud-conf and new-style clouds-yaml config, it would be good for tooling to recognize cluster-classes doing one or the other.
This cloud be done by an annotation (or a label) like here: 16f5342
Then tooling would just look at the cluster-class label ... like here: SovereignCloudStack/scs-training-kaas-scripts@8110c6b
Thoughts?

@@ -1,10 +1,15 @@
apiVersion: v2
type: application
dependencies:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates the dependencies: section rather than just moving it so yamllint rightly complains.

name: cilium
repository: https://helm.cilium.io/
version: 1.17.4
version: 1.17.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yamllint wants a newline at the end of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants