Skip to content

Feat/add orc image #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025
Merged

Feat/add orc image #221

merged 3 commits into from
Apr 4, 2025

Conversation

jschoone
Copy link
Contributor

@jschoone jschoone commented Apr 3, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@jschoone jschoone requested a review from garloff April 3, 2025 12:31
@jschoone
Copy link
Contributor Author

jschoone commented Apr 3, 2025

Hi @garloff, this adds the ORC image, if you want to test that.
If that works we can build stable versions.
Unfortunately the images here currently don't match the SCS Standards

@berendt
Copy link

berendt commented Apr 3, 2025

Unfortunately the images here currently don't match the SCS Standards

Why not? I was not previously aware that anything had to be changed there. Feel free to open a PR to improve the image to match the SCS standards again.

@garloff
Copy link
Member

garloff commented Apr 3, 2025

It's probably some of the metadata from https://docs.scs.community/standards/scs-0102-v1-image-metadata/ that's missing? The ORC should probably allow for these to be fed when registering the image. Properties can also be adjusted after registration, in case we need a postprocessing step.

Notes: scs-0102 only mandates things for provider-provided (public/community) images. So a customer using ORC to register images in her own tenant may ignore the settings. However, for efficiency having the cloud provider register the images makes a lot of sense, especially when using ceph's COW feature for raw images.

@berendt
Copy link

berendt commented Apr 3, 2025

It's probably some of the metadata from https://docs.scs.community/standards/scs-0102-v1-image-metadata/ that's missing?

The metadata is only added when the image is uploaded. This has nothing to do with the content of the image itself.

@jschoone
Copy link
Contributor Author

jschoone commented Apr 3, 2025

Versions are too old. Maybe this just needs to be merged?

@jschoone jschoone force-pushed the feat/add_orc_image branch from e7c52d7 to 985607e Compare April 4, 2025 08:03
@jschoone jschoone force-pushed the feat/add_orc_image branch from 985607e to 8e01208 Compare April 4, 2025 08:08
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jschoone jschoone merged commit 5100655 into main Apr 4, 2025
4 checks passed
@jschoone jschoone deleted the feat/add_orc_image branch April 4, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants