-
Notifications
You must be signed in to change notification settings - Fork 7
Feat/add orc image #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add orc image #221
Conversation
Why not? I was not previously aware that anything had to be changed there. Feel free to open a PR to improve the image to match the SCS standards again. |
It's probably some of the metadata from https://docs.scs.community/standards/scs-0102-v1-image-metadata/ that's missing? The ORC should probably allow for these to be fed when registering the image. Properties can also be adjusted after registration, in case we need a postprocessing step. Notes: scs-0102 only mandates things for provider-provided (public/community) images. So a customer using ORC to register images in her own tenant may ignore the settings. However, for efficiency having the cloud provider register the images makes a lot of sense, especially when using ceph's COW feature for raw images. |
The metadata is only added when the image is uploaded. This has nothing to do with the content of the image itself. |
Versions are too old. Maybe this just needs to be merged? |
e7c52d7
to
985607e
Compare
Signed-off-by: Jan Schoone <[email protected]>
Signed-off-by: Jan Schoone <[email protected]> Signed-off-by: Jan Schoone <[email protected]>
Signed-off-by: Jan Schoone <[email protected]>
985607e
to
8e01208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: