-
Notifications
You must be signed in to change notification settings - Fork 84
Fix building with node 10.0.0 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
79f33dd
54ef6b6
a8e5ba0
8c4007c
1844ec1
dc48bf0
70c52de
c6e57d2
af15d6c
07c6f0c
6407b83
f71920e
c76789c
9f3bdd1
4014005
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,9 @@ addons: | |
language: node_js | ||
node_js: | ||
- "stable" | ||
- "9.0" | ||
- "8.0" | ||
- "6.0" | ||
- "4.0" | ||
- "0.12" | ||
- "0.10" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,19 +3,20 @@ | |
|
||
// Include header for addon version, node/v8 inclusions, etc. | ||
#include <addon.h> | ||
#include <node_version.h> | ||
#include <nan.h> | ||
#include <node_version.h> | ||
#include <string> | ||
|
||
// OpenSSL headers | ||
#include <openssl/asn1.h> | ||
#include <openssl/bio.h> | ||
#include <openssl/bn.h> | ||
#include <openssl/err.h> | ||
#include <openssl/opensslv.h> | ||
#include <openssl/pem.h> | ||
#include <openssl/x509.h> | ||
#include <openssl/x509v3.h> | ||
#include <openssl/x509_vfy.h> | ||
#include <openssl/bn.h> | ||
#include <openssl/x509v3.h> | ||
|
||
using namespace v8; | ||
|
||
|
@@ -25,13 +26,13 @@ NAN_METHOD(get_issuer); | |
NAN_METHOD(parse_cert); | ||
NAN_METHOD(verify); | ||
|
||
Local<Value> try_parse(const std::string& dataString); | ||
Local<Value> verify(const std::string& dataString); | ||
Local<Value> try_parse(const std::string &dataString); | ||
Local<Value> verify(const std::string &dataString); | ||
Local<Value> parse_date(ASN1_TIME *date); | ||
Local<Value> parse_serial(ASN1_INTEGER *serial); | ||
Local<Object> parse_name(X509_NAME *subject); | ||
|
||
char* real_name(char *data); | ||
char* trim(char *data, int len); | ||
char *real_name(char *data); | ||
char *trim(char *data, int len); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto. |
||
|
||
#endif |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,6 @@ | |
}, | ||
"license": "MIT", | ||
"dependencies": { | ||
"nan": "2.2.0" | ||
"nan": "2.10.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,26 @@ | ||
#include <cstdlib> | ||
#include <cstdio> | ||
#include <cstdlib> | ||
|
||
#include <addon.h> | ||
#include <x509.h> | ||
|
||
using namespace v8; | ||
|
||
void init(Local<Object> exports) { | ||
Nan::Set(exports, | ||
Nan::New<String>("version").ToLocalChecked(), | ||
Nan::New<String>(VERSION).ToLocalChecked()); | ||
Nan::Set(exports, Nan::New<String>("version").ToLocalChecked(), | ||
Nan::New<String>(VERSION).ToLocalChecked()); | ||
|
||
Nan::Set(exports, | ||
Nan::New<String>("verify").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(verify)->GetFunction()); | ||
Nan::Set(exports, Nan::New<String>("verify").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(verify)->GetFunction()); | ||
|
||
Nan::Set(exports, | ||
Nan::New<String>("getAltNames").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(get_altnames)->GetFunction()); | ||
Nan::Set(exports, | ||
Nan::New<String>("getSubject").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(get_subject)->GetFunction()); | ||
Nan::Set(exports, | ||
Nan::New<String>("getIssuer").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(get_issuer)->GetFunction()); | ||
Nan::Set(exports, | ||
Nan::New<String>("parseCert").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(parse_cert)->GetFunction()); | ||
Nan::Set(exports, Nan::New<String>("getAltNames").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(get_altnames)->GetFunction()); | ||
Nan::Set(exports, Nan::New<String>("getSubject").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(get_subject)->GetFunction()); | ||
Nan::Set(exports, Nan::New<String>("getIssuer").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(get_issuer)->GetFunction()); | ||
Nan::Set(exports, Nan::New<String>("parseCert").ToLocalChecked(), | ||
Nan::New<FunctionTemplate>(parse_cert)->GetFunction()); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use the 2 spaces as indents. |
||
|
||
NODE_MODULE(x509, init) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please revert these style changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wish someone just edited these files using github inline edit :)