docs: add CSS utility class guidelines to typography spec - #1371
Open
otsimaofficial wants to merge 1 commit into
Open
docs: add CSS utility class guidelines to typography spec#1371otsimaofficial wants to merge 1 commit into
otsimaofficial wants to merge 1 commit into
Conversation
The typography hierarchy doc already covered fonts, the type scale, line-height, and Figma text styles. Adds the missing piece from the issue's acceptance criteria: explicit do/don't guidance for which Tailwind utility classes to reach for at each hierarchy level, so new components stay consistent with the existing scale.
|
@otsimaofficial Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #972 — typography and hierarchy guidelines for the terminal UI.
docs/design-specs/typography.mdalready covered font families, the type scale, line-height matrix, color pairings, and Figma text style definitions in detail. This adds the one piece the issue's acceptance criteria called for that was still missing: a CSS utility class guidelines section — explicit do/don't rules for which Tailwind classes map to which hierarchy level (headings, labels, body, badges, etc.), so new components stay consistent with the documented scale instead of introducing one-off sizes/weights.The Figma text style definitions criterion was already satisfied by the existing §9 ("Figma Font Plugin Setup" / text style definitions in §5) prior to this PR.
Test plan
docs/design-specs/typography.md); no code paths affected.🤖 Generated with Claude Code