feat: Add CAD display submodule #93
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56815ad35c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| AddEventHandler("playerDropped", function() | ||
| local changed = false | ||
| for vehNet, owner in pairs(displayOwners) do | ||
| if owner == source then | ||
| displayOwners[vehNet] = nil |
There was a problem hiding this comment.
Ownership of a vehicle’s CAD display is stored per vehicle and only cleared on player disconnect (see playerDropped handler). Because takeover in ClaimDisplay requires the current owner to approve, if a player claims a display and simply exits the vehicle, they remain owner indefinitely; takeover requests from new occupants will keep timing out and the display will never update screenshots for them. Ownership needs to be released when the vehicle is vacated or the owner leaves so subsequent occupants can control the display.
Useful? React with 👍 / 👎.
move stream file
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8d88403af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| end | ||
|
|
||
| TriggerServerEvent("SonoranCAD::caddisplay::ClaimDisplay", vehNet) | ||
| notify("You are now controlling this CAD display.") |
There was a problem hiding this comment.
The client sends SonoranCAD::caddisplay::ClaimDisplay with only the vehicle net ID and never passes the player’s seat (TriggerServerEvent("...", vehNet)), so when a display already has an owner the server sees claimedSeat == nil and rejects the takeover with “Only the driver or front passenger can take control.” (see sv_caddisplay.lua lines 249‑276). As a result, even the driver/front passenger cannot request control from an existing owner, making the handoff flow unusable whenever a display is already claimed.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 683b2970c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local function checkPermissions(src) | ||
| if not pluginConfig.commands.restricted then | ||
| return true, true | ||
| end | ||
|
|
There was a problem hiding this comment.
When commands.restricted is false (the default in caddisplay_config.dist.lua), checkPermissions returns (true, true), marking every caller as an admin. That means any player can call SavePlacement/DeletePlacement and persistently add or remove CAD display placements without ACE/framework/custom approval. This effectively bypasses the intended admin-only guard as soon as the feature is enabled.
Useful? React with 👍 / 👎.
| local seat = getSeatIndexForPed(veh, ped) | ||
| TriggerServerEvent("SonoranCAD::caddisplay::ClaimDisplay", vehNet, seat) | ||
| notify("You are now controlling this CAD display.") | ||
| claimedOnce[tostring(vehNet)] = true |
There was a problem hiding this comment.
The interact command always notifies "You are now controlling this CAD display" and marks the vehicle as claimed immediately after sending SonoranCAD::caddisplay::ClaimDisplay, without waiting for the server response. If the server rejects or defers the claim (e.g., another owner exists and you are not the driver/front passenger, or the current owner denies), the player still sees a success message and the prompt is suppressed even though control was not granted.
Useful? React with 👍 / 👎.
…s in both caddisplay and tablet modules
Description
Motivation and Context
How Has This Been Tested?
Contributor License Agreement
By submitting this pull request, you certify that you have read and agree to the project’s Contributor License Agreement (CLA) under the PolyForm Noncommercial 1.0.0 license.
(Replace
<GitHub Handle>with your GitHub username.)Checklist