-
Notifications
You must be signed in to change notification settings - Fork 14
feat(tablet): new functionality for frameworks #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(tablet): new functionality for frameworks #69
Conversation
As described on Discord: [https://discord.com/channels/611781170895781888/1392992430466404402/1392992430466404402](https://discord.com/channels/611781170895781888/1392992430466404402/1392992430466404402) ### Features * Added config option to **auto-hide the mini-CAD** when a player exits a vehicle and automatically restore it when they re-enter * Added new config options to **restrict CAD access** unless one of the following conditions is met: * **QB & ESX**: Player possesses a specific item (e.g., a tablet) in their inventory * **QB & ESX**: Character belongs to the appropriate job/faction—units will only display if relevant * **QB & ESX**: Character holds a permitted job (CAD access based on job) * Player is inside a **whitelisted emergency vehicle** ### Testing * Light testing performed; new config options are working as expected * No UI-specific issues observed—any attach/detach or refresh-related delays appear to stem from backend behavior
Fix Issue with commit
Damn Lines
feat(vehreg): Add Make and Year support, fix customData nil bug
…FiveM; branch 'master' of github.com:Sonoran-Software/SonoranCADFiveM into feat-functionality
Fireant456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR first off! We appreciate your continued contributions to this project.
I have identified some items we have not explicitly laid out in the original bounty but are considerations for user experience. We would like to move the configuration file items you have made from tablet/config.lua to sonorancad/configuration/tablet_config.dist.lua. This will require utilizing your new export for getting that configuration settings from the core resource. We also identified that the default configuration doesn't fully mimic the default behavior of the existing tablet resource. We want you to revise those settings to match the current behavior out of the box. Basically with all the new configurations in the disabled state.
QA Round 1:
- Move
tablet/config.luatosonorancad/configuration/tablet_config.dist.luaand handle passing configuration through exports. - Revise default configuration to match current "default" behavior.
fixed something i forgot to update in the new config method
|
Sorry for the delay in getting this run through QA again, we notice some minor issues right off the bat that will need to be corrected.
|
Fireant456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #69 (comment)
As described on Discord: https://discord.com/channels/611781170895781888/1392992430466404402/1392992430466404402
Features
Added config option to auto-hide the mini-CAD when a player exits a vehicle and automatically restore it when they re-enter
Added new config options to restrict CAD access unless one of the following conditions is met:
Testing