Add repro for NET-882

SonarSource · Jan 29, 2025 · 9144165 · 9144165
1 parent 523faac
commit 9144165
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 0 deletions.
diff --git a/...yzers/tests/SonarAnalyzer.Test/TestCases/RedundantDeclaration.CSharp12.ArraySize.Fixed.cs b/...yzers/tests/SonarAnalyzer.Test/TestCases/RedundantDeclaration.CSharp12.ArraySize.Fixed.cs
@@ -72,3 +72,22 @@ void VarDeclarationWithReassignmentToEmptyCollection()
         }
     }
 }
+
+// https://sonarsource.atlassian.net/browse/NET-882
+namespace ReproNET882
+{
+    public class ReproNet882
+    {
+        public void Method()
+        {
+            // In this example Action<object, RoutedEventArgs> is down-casted by AddHandler to EventHandler  (EventHandler has the exact same definition as the Action but they are different).
+            AddHandler(OnErrorEvent);
+            AddHandler(new EventHandler(OnErrorEvent)); // Fixed
+        }
+        private void OnErrorEvent(object sender, EventArgs e) { }
+
+        public void AddHandler(Delegate handler)
+        {
+        }
+    }
+}
diff --git a/...s/SonarAnalyzer.Test/TestCases/RedundantDeclaration.CSharp12.LambdaParameterType.Fixed.cs b/...s/SonarAnalyzer.Test/TestCases/RedundantDeclaration.CSharp12.LambdaParameterType.Fixed.cs
@@ -72,3 +72,22 @@ void VarDeclarationWithReassignmentToEmptyCollection()
         }
     }
 }
+
+// https://sonarsource.atlassian.net/browse/NET-882
+namespace ReproNET882
+{
+    public class ReproNet882
+    {
+        public void Method()
+        {
+            // In this example Action<object, RoutedEventArgs> is down-casted by AddHandler to EventHandler  (EventHandler has the exact same definition as the Action but they are different).
+            AddHandler(OnErrorEvent);
+            AddHandler(new EventHandler(OnErrorEvent)); // Fixed
+        }
+        private void OnErrorEvent(object sender, EventArgs e) { }
+
+        public void AddHandler(Delegate handler)
+        {
+        }
+    }
+}
diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/RedundantDeclaration.CSharp12.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/RedundantDeclaration.CSharp12.cs
@@ -72,3 +72,22 @@ void VarDeclarationWithReassignmentToEmptyCollection()
         }
     }
 }
+
+// https://sonarsource.atlassian.net/browse/NET-882
+namespace ReproNET882
+{
+    public class ReproNet882
+    {
+        public void Method()
+        {
+            // In this example Action<object, RoutedEventArgs> is down-casted by AddHandler to EventHandler  (EventHandler has the exact same definition as the Action but they are different).
+            AddHandler(OnErrorEvent);
+            AddHandler(new EventHandler(OnErrorEvent)); // Noncompliant FP, the inferred natural type is wrong and therefore an explicit delegate creation is needed. This is relevant for C# 10 and later.
+        }
+        private void OnErrorEvent(object sender, EventArgs e) { }
+
+        public void AddHandler(Delegate handler)
+        {
+        }
+    }
+}