Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@denis-troller denis-troller changed the title Create rule S8125 Create rule S8125: Field-level permissions should be checked before accessing fields Sep 29, 2025
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: build-and-deploy

Failed stage: Deploy 🚀 [❌]

Failure summary:

The action failed during the GitHub Pages deploy step due to a forced push being rejected by the
remote:
- Git push error: cannot lock ref 'refs/heads/gh-pages': is at
a572fa7c87960bda722c44b4b79ddd5efc193693 but expected 347c08053e5be33154d2f9ad1804c8b9aafb10fc
(lines 846–848).
- This indicates the remote gh-pages branch changed between fetch and push
(concurrent update), so the deploy commit based on an outdated ref could not be pushed.
- As a
result, the deploy step exited with code 1 and the workflow failed (lines 851–852).
Additional
earlier errors observed (JSON parse error for rules/S7472/python/metadata.json and "No languages
found") did not stop the build but may indicate data issues; the terminal failure was the push
rejection on gh-pages.

Relevant error logs:
1:  Runner name: 'github-ubuntu-latest-s_c07c82be129d'
2:  Runner group name: 'github'
...

130:  ##[endgroup]
131:  npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
132:  npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
133:  npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
134:  npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
135:  npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
136:  added 412 packages, and audited 413 packages in 14s
137:  63 packages are looking for funding
138:  run `npm fund` for details
139:  found 0 vulnerabilities
140:  > [email protected] predeploy
141:  > npm run prepare-rules && npm run build
142:  > [email protected] prepare-rules
143:  > ts-node -P tsconfig-rules.json ./src/deployment/index.ts
144:  When parsing the JSON file /home/runner/work/rspec/rspec/frontend/incomplete-rules-repo/rules/S7472/python/metadata.json
145:  {"level":"error","message":"Failed to process PR (https://github.com/SonarSource/rspec/pull/4914), it will be skipped (SyntaxError: Expected double-quoted property name in JSON at position 493)","source":"pullRequestIndexing.ts"}
146:  {"level":"error","message":"No languages found for rule S7472, at least 1 is required","source":"searchIndex.ts"}
147:  > [email protected] build
...

260:  * [new branch]            feat/smarini/BUILD-6088-add-security-md -> origin/feat/smarini/BUILD-6088-add-security-md
261:  * [new branch]            feat/sonartech/BUILD-8875-changeRunnersNames -> origin/feat/sonartech/BUILD-8875-changeRunnersNames
262:  * [new branch]            feature/education       -> origin/feature/education
263:  * [new branch]            feature/education-backup -> origin/feature/education-backup
264:  * [new branch]            feature/education-new-checks -> origin/feature/education-new-checks
265:  * [new branch]            feature/education-new-checks-rebased -> origin/feature/education-new-checks-rebased
266:  * [new branch]            feature/education-updated -> origin/feature/education-updated
267:  * [new branch]            fix-cloudformation-s6295 -> origin/fix-cloudformation-s6295
268:  * [new branch]            fix-uncatched-promise   -> origin/fix-uncatched-promise
269:  * [new branch]            fix/re-bot/ownership    -> origin/fix/re-bot/ownership
270:  * [new branch]            fix/typo/S5131          -> origin/fix/typo/S5131
271:  * [new branch]            ft/cleaning             -> origin/ft/cleaning
272:  * [new branch]            ft/common3              -> origin/ft/common3
273:  * [new branch]            ft/cppcoreguidelines    -> origin/ft/cppcoreguidelines
274:  * [new branch]            ft/dirty-security-apply -> origin/ft/dirty-security-apply
275:  * [new branch]            ft/fix-error-login      -> origin/ft/fix-error-login
276:  * [new branch]            ft/moreupdate           -> origin/ft/moreupdate
...

833:  ?? rules/S8126/
834:  ?? rules/S8127/
835:  ?? rules/S8128/
836:  ?? rules/S8129/
837:  ?? rules/S8130/
838:  ?? rules/S8131/
839:  ?? rules/S8132/
840:  ?? rules/S8133/
841:  [command]/usr/bin/git add --all .
842:  [command]/usr/bin/git checkout -b github-pages-deploy-action/6aq0bfwjm
843:  Switched to a new branch 'github-pages-deploy-action/6aq0bfwjm'
844:  [command]/usr/bin/git commit -m Deploying to gh-pages from  @ 1bbdf2f38a0ef1aba644801b9c26c9cfb7669324 🚀 --quiet --no-verify
845:  [command]/usr/bin/git push --force ***github.com/SonarSource/rspec.git github-pages-deploy-action/6aq0bfwjm:gh-pages
846:  To https://github.com/SonarSource/rspec.git
847:  ! [remote rejected]       github-pages-deploy-action/6aq0bfwjm -> gh-pages (cannot lock ref 'refs/heads/gh-pages': is at a572fa7c87960bda722c44b4b79ddd5efc193693 but expected 347c08053e5be33154d2f9ad1804c8b9aafb10fc)
848:  error: failed to push some refs to 'https://github.com/SonarSource/rspec.git'
849:  Running post deployment cleanup jobs… 🗑️
850:  [command]/usr/bin/git worktree remove github-pages-deploy-action-temp-deployment-folder --force
851:  ##[error]The deploy step encountered an error: The process '/usr/bin/git' failed with exit code 1 ❌
852:  Deployment failed! ❌
853:  Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant