Create rule S8040: SOQL queries should not be placed inside loops

[github-actions]

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

• logical errors and incorrect information
• information gaps and missing content
• text style and tone
• PR summary and labels follow the guidelines

[sonarqube-next]

Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[sonarqube-next]

Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[qodo-merge-pro]

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: build-and-deploy

Failed stage: Deploy 🚀 [❌]

Failure summary: The GitHub Pages deployment step failed when pushing to the gh-pages branch: - Git push was rejected with: "cannot lock ref refs/heads/gh-pages: is at 029aae6 but expected 0ea64df" (lines 844-845). - This indicates the remote gh-pages branch advanced between fetch and push (non-fast-forward/update race), so the forced push targeted an unexpected commit SHA. - As a result, /usr/bin/git exited with code 1 and the deploy step failed (line 848).

Relevant error logs: 1: Runner name: 'github-ubuntu-latest-s_faade67bb05a' 2: Runner group name: 'github' ... 130: ##[endgroup] 131: npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. 132: npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported 133: npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5. 134: npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5. 135: npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5. 136: added 412 packages, and audited 413 packages in 10s 137: 63 packages are looking for funding 138: run `npm fund` for details 139: found 0 vulnerabilities 140: > [email protected] predeploy 141: > npm run prepare-rules && npm run build 142: > [email protected] prepare-rules 143: > ts-node -P tsconfig-rules.json ./src/deployment/index.ts 144: When parsing the JSON file /home/runner/work/rspec/rspec/frontend/incomplete-rules-repo/rules/S7472/python/metadata.json 145: {"level":"error","message":"Failed to process PR (https://github.com/SonarSource/rspec/pull/4914), it will be skipped (SyntaxError: Expected double-quoted property name in JSON at position 493)","source":"pullRequestIndexing.ts"} 146: {"level":"error","message":"No languages found for rule S7472, at least 1 is required","source":"searchIndex.ts"} 147: > [email protected] build ... 260: * [new branch] feat/smarini/BUILD-6088-add-security-md -> origin/feat/smarini/BUILD-6088-add-security-md 261: * [new branch] feat/sonartech/BUILD-8875-changeRunnersNames -> origin/feat/sonartech/BUILD-8875-changeRunnersNames 262: * [new branch] feature/education -> origin/feature/education 263: * [new branch] feature/education-backup -> origin/feature/education-backup 264: * [new branch] feature/education-new-checks -> origin/feature/education-new-checks 265: * [new branch] feature/education-new-checks-rebased -> origin/feature/education-new-checks-rebased 266: * [new branch] feature/education-updated -> origin/feature/education-updated 267: * [new branch] fix-cloudformation-s6295 -> origin/fix-cloudformation-s6295 268: * [new branch] fix-uncatched-promise -> origin/fix-uncatched-promise 269: * [new branch] fix/re-bot/ownership -> origin/fix/re-bot/ownership 270: * [new branch] fix/typo/S5131 -> origin/fix/typo/S5131 271: * [new branch] ft/cleaning -> origin/ft/cleaning 272: * [new branch] ft/common3 -> origin/ft/common3 273: * [new branch] ft/cppcoreguidelines -> origin/ft/cppcoreguidelines 274: * [new branch] ft/dirty-security-apply -> origin/ft/dirty-security-apply 275: * [new branch] ft/fix-error-login -> origin/ft/fix-error-login 276: * [new branch] ft/moreupdate -> origin/ft/moreupdate ... 830: M rules/S8042/default-metadata.json 831: M rules/S8043/apex-description.html 832: M rules/S8043/apex-metadata.json 833: M rules/S8043/default-description.html 834: M rules/S8043/default-metadata.json 835: M rules/rule-index-aggregates.json 836: M rules/rule-index-store.json 837: M rules/rule-index.json 838: [command]/usr/bin/git add --all . 839: [command]/usr/bin/git checkout -b github-pages-deploy-action/snujh16fb 840: Switched to a new branch 'github-pages-deploy-action/snujh16fb' 841: [command]/usr/bin/git commit -m Deploying to gh-pages from @ b3b2dcc3b07a319b0b8c05e2d9d0783b0fa55949 🚀 --quiet --no-verify 842: [command]/usr/bin/git push --force ***github.com/SonarSource/rspec.git github-pages-deploy-action/snujh16fb:gh-pages 843: To https://github.com/SonarSource/rspec.git 844: ! [remote rejected] github-pages-deploy-action/snujh16fb -> gh-pages (cannot lock ref 'refs/heads/gh-pages': is at 029aae620c1dc56758abb9937d69fe3d29b745d2 but expected 0ea64df4a4350ed351a1a3a11289977309ff0426) 845: error: failed to push some refs to 'https://github.com/SonarSource/rspec.git' 846: Running post deployment cleanup jobs… 🗑️ 847: [command]/usr/bin/git worktree remove github-pages-deploy-action-temp-deployment-folder --force 848: ##[error]The deploy step encountered an error: The process '/usr/bin/git' failed with exit code 1 ❌ 849: Deployment failed! ❌ 850: Post job cleanup.