Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@denis-troller denis-troller changed the title Create rule S8038 Create rule S8038: SOQL queries should use built-in security enforcement instead of manual Schema accessibility checks Sep 29, 2025
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: build-and-deploy

Failed stage: Deploy 🚀 [❌]

Failure summary:

The GitHub Pages deploy step failed due to a non-fast-forward push conflict on branch gh-pages:
-
Remote rejected the push: cannot lock ref 'refs/heads/gh-pages': is at
0ea64df4a4350ed351a1a3a11289977309ff0426 but expected 36be9bbb6491a096281f4b1b102f777df2b56ad4
(lines 844–845).
- This indicates gh-pages advanced on the remote after the local commit was
prepared, causing the forced push to target an outdated expected ref.
- As a result, /usr/bin/git
push exited with code 1 and the deployment failed (lines 848–849).

Additional warnings/errors earlier (e.g., JSON parse error for rules/S7472/python/metadata.json and
"No languages found for rule S7472") did not stop the build but may affect content; they are not the
terminal cause of the action failure.

Relevant error logs:
1:  Runner name: 'github-ubuntu-latest-s_2f7284399725'
2:  Runner group name: 'github'
...

131:  ##[endgroup]
132:  npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
133:  npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
134:  npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
135:  npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
136:  npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
137:  added 412 packages, and audited 413 packages in 13s
138:  63 packages are looking for funding
139:  run `npm fund` for details
140:  found 0 vulnerabilities
141:  > [email protected] predeploy
142:  > npm run prepare-rules && npm run build
143:  > [email protected] prepare-rules
144:  > ts-node -P tsconfig-rules.json ./src/deployment/index.ts
145:  When parsing the JSON file /home/runner/work/rspec/rspec/frontend/incomplete-rules-repo/rules/S7472/python/metadata.json
146:  {"level":"error","message":"Failed to process PR (https://github.com/SonarSource/rspec/pull/4914), it will be skipped (SyntaxError: Expected double-quoted property name in JSON at position 493)","source":"pullRequestIndexing.ts"}
147:  {"level":"error","message":"No languages found for rule S7472, at least 1 is required","source":"searchIndex.ts"}
148:  > [email protected] build
...

261:  * [new branch]            feat/smarini/BUILD-6088-add-security-md -> origin/feat/smarini/BUILD-6088-add-security-md
262:  * [new branch]            feat/sonartech/BUILD-8875-changeRunnersNames -> origin/feat/sonartech/BUILD-8875-changeRunnersNames
263:  * [new branch]            feature/education       -> origin/feature/education
264:  * [new branch]            feature/education-backup -> origin/feature/education-backup
265:  * [new branch]            feature/education-new-checks -> origin/feature/education-new-checks
266:  * [new branch]            feature/education-new-checks-rebased -> origin/feature/education-new-checks-rebased
267:  * [new branch]            feature/education-updated -> origin/feature/education-updated
268:  * [new branch]            fix-cloudformation-s6295 -> origin/fix-cloudformation-s6295
269:  * [new branch]            fix-uncatched-promise   -> origin/fix-uncatched-promise
270:  * [new branch]            fix/re-bot/ownership    -> origin/fix/re-bot/ownership
271:  * [new branch]            fix/typo/S5131          -> origin/fix/typo/S5131
272:  * [new branch]            ft/cleaning             -> origin/ft/cleaning
273:  * [new branch]            ft/common3              -> origin/ft/common3
274:  * [new branch]            ft/cppcoreguidelines    -> origin/ft/cppcoreguidelines
275:  * [new branch]            ft/dirty-security-apply -> origin/ft/dirty-security-apply
276:  * [new branch]            ft/fix-error-login      -> origin/ft/fix-error-login
277:  * [new branch]            ft/moreupdate           -> origin/ft/moreupdate
...

830:  M rules/S8040/default-metadata.json
831:  M rules/S8041/apex-description.html
832:  M rules/S8041/apex-metadata.json
833:  M rules/S8041/default-description.html
834:  M rules/S8041/default-metadata.json
835:  M rules/rule-index-aggregates.json
836:  M rules/rule-index-store.json
837:  M rules/rule-index.json
838:  [command]/usr/bin/git add --all .
839:  [command]/usr/bin/git checkout -b github-pages-deploy-action/23rva3qmv
840:  Switched to a new branch 'github-pages-deploy-action/23rva3qmv'
841:  [command]/usr/bin/git commit -m Deploying to gh-pages from  @ c973a126b2f33bc3e2d6ce877e625bc579a85ff0 🚀 --quiet --no-verify
842:  [command]/usr/bin/git push --force ***github.com/SonarSource/rspec.git github-pages-deploy-action/23rva3qmv:gh-pages
843:  To https://github.com/SonarSource/rspec.git
844:  ! [remote rejected]       github-pages-deploy-action/23rva3qmv -> gh-pages (cannot lock ref 'refs/heads/gh-pages': is at 0ea64df4a4350ed351a1a3a11289977309ff0426 but expected 36be9bbb6491a096281f4b1b102f777df2b56ad4)
845:  error: failed to push some refs to 'https://github.com/SonarSource/rspec.git'
846:  Running post deployment cleanup jobs… 🗑️
847:  [command]/usr/bin/git worktree remove github-pages-deploy-action-temp-deployment-folder --force
848:  ##[error]The deploy step encountered an error: The process '/usr/bin/git' failed with exit code 1 ❌
849:  Deployment failed! ❌
850:  Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant