Introduce Django #119
Draft
Introduce Django #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This is my first attempt at integrating Django with Pyctuator.
It's not finished yet, but I wanted to get your opinion first. The code isn't clean and, among other things, the disabled_endpoints part is missing.
I've implemented it using the same strategy as for the other Frameworks. However, I wonder if it wouldn't be better for django
to create a Django application with urls and middelware.
Indeed, in this PR, I modify the settings of django behind de scene. This doesn't seem to me to follow the Django philosophy.
For me, having a Django app in the pyctuator project would be the best solution.
All the user would have to do is configure the /pyctuator endpoint on the ROOT_URLS and add the middleware needed to track traces.