-
-
Notifications
You must be signed in to change notification settings - Fork 4
Apply PR review feedback: type safety, tsconfig coverage, dep classification, async cleanup, and missing surface stubs #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/add-minimal-stubs-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3abf594
Initial plan
Copilot 69db37f
feat: add minimal buildable stubs for SDK, API, app surfaces and inte…
Copilot b3375ec
fix: apply PR review feedback — types, tsconfig jsx, async cleanup, d…
Copilot 9be4d44
feat: add missing stubs and scripts — dashboard, terminal, contracts …
Copilot 4f1073e
Update main.tsx
SolanaRemix 6ea9b40
Update package.json
SolanaRemix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { app } from "./server"; | ||
|
|
||
| const port = Number(process.env.PORT) || 4000; | ||
| app.listen(port, () => console.log(`API listening on :${port}`)); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import express from "express"; | ||
|
|
||
| const app = express(); | ||
|
|
||
| app.get("/contracts", (_req, res) => { | ||
|
Check failure on line 5 in api/src/server.ts
|
||
| // minimal placeholder that returns an empty array | ||
| res.json([]); | ||
| }); | ||
|
|
||
| app.get("/health", (_req, res) => { | ||
|
Check failure on line 10 in api/src/server.ts
|
||
| res.json({ status: "ok" }); | ||
| }); | ||
|
|
||
| export { app }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import React from "react"; | ||
| import { createRoot } from "react-dom/client"; | ||
| import { AppRouter } from "./router"; | ||
|
|
||
| createRoot(document.getElementById("root")!).render( | ||
| <React.StrictMode> | ||
| <AppRouter /> | ||
| </React.StrictMode> | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import React from "react"; | ||
|
|
||
| export function AppRouter() { | ||
| return <div>CyberAi</div>; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import React from "react"; | ||
| import { createRoot } from "react-dom/client"; | ||
|
|
||
| function Dashboard() { | ||
| return <div>CyberAi Dashboard</div>; | ||
| } | ||
|
|
||
| if (typeof document !== "undefined") { | ||
| const rootElement = document.getElementById("root"); | ||
| if (rootElement) { | ||
| createRoot(rootElement).render( | ||
| <React.StrictMode> | ||
| <Dashboard /> | ||
| </React.StrictMode> | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
tsconfig.jsondoes not includeapp/src/**/*.tsxin itsincludearray, and has no"jsx"compiler option set. Runningnpm run typecheckwill not type-check these new files, andnpm run build(tsc) will not compile them. The tsconfig needs both"jsx": "react-jsx"incompilerOptionsand"app/src/**/*"in theincludearray for these files to be properly compiled.