Skip to content

Apply PR review feedback: type safety, tsconfig coverage, dep classification, async cleanup, and missing surface stubs #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Apply PR review feedback: type safety, tsconfig coverage, dep classification, async cleanup, and missing surface stubs #90

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3abf594
Initial plan
Copilot Mar 8, 2026
69db37f
feat: add minimal buildable stubs for SDK, API, app surfaces and inte…
Copilot Mar 8, 2026
b3375ec
fix: apply PR review feedback — types, tsconfig jsx, async cleanup, d…
Copilot Mar 8, 2026
9be4d44
feat: add missing stubs and scripts — dashboard, terminal, contracts …
Copilot Mar 8, 2026
4f1073e
Update main.tsx
SolanaRemix Mar 8, 2026
6ea9b40
Update package.json
SolanaRemix Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { app } from "./server";

const port = Number(process.env.PORT) || 4000;
app.listen(port, () => console.log(`API listening on :${port}`));
14 changes: 14 additions & 0 deletions api/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import express from "express";

const app = express();

app.get("/contracts", async (_req, res) => {
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /contracts route handler is marked async but contains no await expressions. This is unnecessary and may generate a TypeScript lint warning. Since there's no asynchronous operation, the async keyword should be removed.

Suggested change
app.get("/contracts", async (_req, res) => {
app.get("/contracts", (_req, res) => {

Copilot uses AI. Check for mistakes.
// minimal placeholder that returns an empty array
res.json([]);
});

app.get("/health", (_req, res) => {
res.json({ status: "ok" });
});

export { app };
9 changes: 9 additions & 0 deletions app/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import React from "react";
import { createRoot } from "react-dom/client";
import { AppRouter } from "./router";

createRoot(document.getElementById("root")!).render(
<React.StrictMode>
<AppRouter />
</React.StrictMode>
);
Comment on lines +1 to +9
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tsconfig.json does not include app/src/**/*.tsx in its include array, and has no "jsx" compiler option set. Running npm run typecheck will not type-check these new files, and npm run build (tsc) will not compile them. The tsconfig needs both "jsx": "react-jsx" in compilerOptions and "app/src/**/*" in the include array for these files to be properly compiled.

Copilot uses AI. Check for mistakes.
5 changes: 5 additions & 0 deletions app/src/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import React from "react";

export function AppRouter() {
return <div>CyberAi</div>;
}
Loading
Loading