Skip to content

Fix ESLint flat config flag, tsconfig moduleResolution, scripts dependency drift, and CI lint workflow #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix ESLint flat config flag, tsconfig moduleResolution, scripts dependency drift, and CI lint workflow #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9d7f8f
Initial plan
Copilot Feb 23, 2026
8013f60
Fix ESLint --ext flag, tsconfig moduleResolution, and scripts depende…
Copilot Feb 23, 2026
b3ff9a5
Fix lint.yml --ext flag and regenerate scripts/package-lock.json
Copilot Mar 2, 2026
1bf09d7
Update package.json
SolanaRemix Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run: npm ci

- name: Run ESLint
run: npx eslint . --ext .js,.ts,.jsx,.tsx --max-warnings 0
run: npm run lint -- --max-warnings 0
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now runs npm run lint while also passing --max-warnings 0, but the lint script itself already includes --max-warnings 0. Dropping the extra CLI args (or removing it from the script instead) avoids duplicating flags and reduces the risk of ESLint rejecting/overriding repeated options.

Suggested change
run: npm run lint -- --max-warnings 0
run: npm run lint

Copilot uses AI. Check for mistakes.

prettier:
name: Prettier
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"test:ui": "vitest --ui",
"test:unit": "vitest run tests/unit",
"test:integration": "vitest run tests/integration",
"lint": "eslint . --ext .js,.ts,.jsx,.tsx",
"lint:fix": "eslint . --ext .js,.ts,.jsx,.tsx --fix",
"lint": "eslint . --max-warnings 0",
"lint:fix": "eslint . --fix",
Comment on lines +20 to +21
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says lint should become eslint . (and CI would pass --max-warnings 0 when needed), but this change hard-codes --max-warnings 0 into the lint script. Decide where warnings should be enforced (script vs CI) and keep it consistent; otherwise this is a behavior change for all local runs and other workflows that call npm run lint (e.g. CI/advanced-build).

Copilot uses AI. Check for mistakes.
"typecheck": "tsc --noEmit",
"format": "prettier --write \"**/*.{js,ts,jsx,tsx,json,yml,yaml,md}\"",
"format:check": "prettier --check \"**/*.{js,ts,jsx,tsx,json,yml,yaml,md}\"",
Expand Down
26 changes: 14 additions & 12 deletions scripts/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"type": "module",
"dependencies": {
"openai": "^6.17.0"
"openai": "^6.18.0"
},
"devDependencies": {
"@types/node": "^25.1.0",
"@types/node": "^25.2.1",
Comment on lines 3 to +7
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/package.json dependency versions were updated, but scripts/package-lock.json still pins the previous openai and @types/node ranges. Please regenerate/update the scripts lockfile so npm ci in scripts/ stays deterministic and consistent with this change.

Copilot uses AI. Check for mistakes.
Copy link
Owner

@SolanaRemix SolanaRemix Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on feedback

Copy link
Contributor Author

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b3ff9a5. Ran npm install in the scripts/ directory to regenerate scripts/package-lock.json. The lockfile now reflects openai: ^6.18.0 (resolved to 6.25.0) and @types/node: ^25.2.1 (resolved to 25.3.3), consistent with the updated scripts/package.json.

"ts-node": "^10.9.2",
Comment on lines +4 to 8
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency bump changes scripts/package.json, but scripts/package-lock.json still pins openai and @types/node to the previous ranges/versions. Please regenerate/update the scripts lockfile so npm ci in scripts/ remains deterministic and consistent with the updated manifest.

Copilot uses AI. Check for mistakes.
Copy link
Owner

@SolanaRemix SolanaRemix Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on feedback

Copy link
Contributor Author

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already addressed in b3ff9a5. scripts/package-lock.json was regenerated via npm install in the scripts/ directory and now reflects openai: ^6.18.0 and @types/node: ^25.2.1.

"typescript": "^5.7.0",
"tsx": "^4.21.0"
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"target": "ES2020",
"module": "ESNext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"esModuleInterop": true,
"resolveJsonModule": true,
"allowSyntheticDefaultImports": true,
Expand Down
Loading