feat(proxy): support Ultrafast service tier - #1734
Conversation
b9526be to
7affd39
Compare
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Reviewed end to end — this is a very clean change. I traced every normalization site ( One small non-blocking note: repurposing Thanks for the thorough OpenSpec artifacts and the before/after screenshots — this made the review straightforward. |
|
Thank you for the thorough review. I merged the latest main to resolve the conflicts and parametrized the integration test to cover both fast → priority and Ultrafast end to end. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughAdds ultrafast service-tier support across API-key validation, dashboard controls, routing and Responses contracts, localization, documentation, and regression tests. Adds Evan Choi to contributor records. ChangesUltrafast service-tier support
Contributor records
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR adds support for the Ultrafast service tier while preserving existing routing and logging behavior. No actionable merge-blocking risk remains based on the supplied evidence. Sequence Diagram(s)sequenceDiagram
participant APIKeyAPI
participant AccountCatalog
participant UpstreamResponsesAPI
participant RequestLog
APIKeyAPI->>AccountCatalog: Check advertised ultrafast tier
AccountCatalog-->>APIKeyAPI: Return eligible account
APIKeyAPI->>UpstreamResponsesAPI: Forward service_tier: ultrafast
UpstreamResponsesAPI-->>APIKeyAPI: Return actual and billable tier
UpstreamResponsesAPI->>RequestLog: Record requested, actual, and effective tiers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
OpenAI added the access-controlled Ultrafast Processing tier, currently documented for
gpt-5.6-solin the Responses API reference. This PR lets codex-lb accept the canonicalservice_tier: "ultrafast"value in API-key policies and the dashboard, then preserve it through the existing Responses routing and logging paths.Type of change
fix:— bug fix (no behavior change beyond the bug)feat:— new user-facing feature or capabilityrefactor:— internal refactor (no behavior change, no API change)docs:— documentation onlychore:/ci:/build:— tooling, CI, packagingtest:— test-only change!after the type, e.g.feat!:or includeBREAKING CHANGE:footer)Linked issue: N/A — no matching issue or discussion was found.
OpenSpec
shape, SSE framing, OAuth flow) and preserves upstream-equivalent behavior
Change directory:
openspec/changes/archive/2026-08-14-support-ultrafast-service-tier/Changes
ultrafastAPI-key enforcement values without normalizing them topriority.Simplicity
simplicity-budget-approvedlabel).env.example/ dashboard nav within budget (none changed)Test plan
OpenSpec verification completed with 7/7 tasks, 3/3 requirements, and 6/6 scenarios covered, with no critical, warning, or suggestion findings. The full main-spec validation remains blocked by existing upstream validation debt; the added
api-keysrequirement validates strictly, and the new requirements add no validation errors.Screenshots / output
Before:
After:
Checklist
<type>(<scope>)?: <subject>).uv run pre-commit run local-ci --hook-stage manual --all-filesor the relevantmake <target>subset locally.openspec validate --specspasses and/opsx:verifyis clean — verification is clean; full spec validation has pre-existing upstream failures described above.Summary by CodeRabbit
New Features
Documentation
Tests