docs: add joschi655 to contributors - #1654
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 170a673d5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ] | ||
| }, | ||
| { | ||
| "login": "joschi655", |
There was a problem hiding this comment.
The config already contains joschi655 at line 1167 with code and test contributions, so adding a second record cannot unblock the coverage check: load_all_contributors() converts logins to a set. It instead leaves conflicting metadata and causes future all-contributors regeneration to render the same person twice; update the existing record if its metadata needs changing rather than appending another one.
Useful? React with 👍 / 👎.
1 participant
Add the author of merged commit af5051f (#1611) to .all-contributorsrc.
This unblocks the Contributors attribution check currently failing on open PR merge heads.