fix(compact): live-carrier for tool search pairs - #1607
Closed
Komzpa wants to merge 78 commits into
Closed
Conversation
The takeover of #1247 hardens selection_failure_response: instead of a private duplicate of the account-cap code set, local capacity codes are resolved via app.core.resilience.overload.LOCAL_OVERLOAD_CODES. This keeps every local overload code (including codes added later, such as the congestion fair-share code from #1536) on the stable 429 rate_limit_error contract, and guarantees the new usage_limit_reached 429 mapping is applied strictly to upstream usage/quota exhaustion of the whole eligible pool. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds externally-routed regressions for the takeover of #1247: - /v1/responses and /backend-api/codex/responses return HTTP 429 with error.type = error.code = usage_limit_reached (and authoritative error.resets_at) when every eligible account is usage-exhausted - resets_at is omitted when selection has no authoritative reset - paused/deactivated/reauth-only pools keep the pre-existing no_accounts semantics, and the synthetic SSE failure keeps the #1479 sequenced response.created/response.failed SDK stream contract - one usable account still fails over with no error Also tightens the OpenSpec delta: authoritative-reset-only resets_at, terminal (non-waitable) usage-limit failures, local capacity codes keep their rate_limit_error contract, owner-scoped exhaustion keeps continuity semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Darafei Praliaskouski <me@komzpa.net>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
the
db migration
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| api_key.id, | ||
| request_id, | ||
| retry_attempt, | ||
| retry_delay_seconds, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporary live-stack carrier based on deployed head
d747bc4986841d3237c2c9db14e0c4767b9f4c94plus the focused compact fix from #1606. This exists because the current recorded overlay list no longer assembles from freshorigin/main: helper assembly conflicts immediately on #1555.The actual new behavior is the same as #1606: preserve
tool_search_call/tool_search_outputpairs during compact input trimming so session019fcc77-8e08-7f02-b5d2-3388c5122004does not send an orphantool_search_outputforcall_d2chifMNZfXqfFWin5jz0dQf.Type of change
fix:— bug fix (no behavior change beyond the bug)Linked issue: none; runtime incident for session
019fcc77-8e08-7f02-b5d2-3388c5122004OpenSpec
Change directory: n/a
Changes
tool_search_callandtool_search_outputto compact pair reconciliation.Test plan