chore(deps): bump jsdom from 29.1.1 to 30.0.0 in /frontend - #1514
chore(deps): bump jsdom from 29.1.1 to 30.0.0 in /frontend#1514dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [jsdom](https://github.com/jsdom/jsdom) from 29.1.1 to 30.0.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.1.1...v30.0.0) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
51721ea to
cd19a08
Compare
|
CI is red on this bump and the failures are deterministic test-harness incompatibilities with jsdom 30, not app regressions — the components' inline styles are unchanged; only how jsdom serializes them changed. Two intentional jsdom 30 behavior changes are responsible:
Total: 7 failed / 937 passed (job 90193268084, head cd19a08). Since dependabot can't fix these, a maintainer needs to push a companion commit to this branch updating the 7 assertions. Suggested approach: assert on the raw inline style attribute (e.g. One more caveat before merging: jsdom 30 raises the Node.js floor to |
|
Superseded by #1586. |
Bumps jsdom from 29.1.1 to 30.0.1 in /frontend, together with the 7 test-assertion updates that the dependabot bump (#1586) cannot carry. Supersedes dependabot's blocked bump; dependabot will auto-close/rebase once main is on 30.0.1. jsdom 30 intentionally changed CSS serialization (see #1514 discussion): - calc() is simplified before serialization, even for inline styles, so authored expressions like calc(5 * 1.75rem) now serialize as calc(8.75rem) - getComputedStyle() converts length values to pixels, so ch-unit expectations via toHaveStyle no longer match The affected assertions now check the raw inline style property (element.style.X) instead of routing through getComputedStyle: simplified calc forms for the 5 maxHeight assertions, and authored ch values (preserved on the inline style) for the 2 minWidth ones. Component code is unchanged. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Bumps jsdom from 29.1.1 to 30.0.0.
Release notes
Sourced from jsdom's releases.
Commits
20a01fc30.0.08c8e583Precompute WPT expectation matchesf32245cBump Node.js floor and dependencies03ef23bAdd background-position longhandsded056fTest CSS.escape() with numeric IDsd312832Convert CSS values to pixels for computed styles4e0ee41Implement CSS.escape() and CSS.supports()05eb709Fix benchmark:compare script on Windows97c1b90Fix CSS function value serialization15642baAdd benchmark comparison script