fix: handle undefined record.id in List component (fixes #1678) #1798
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hers#1678) - Add null check before calling toString() on record.id - Use String() instead of toString() for safer conversion - Prevents TypeError when BaseRecord.id() returns undefined Fixes SoftwareBrothers#1678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1678
This PR fixes the
TypeError: can't access property "toString", r.id is undefinederror that occurs in the List component whenBaseRecord.id()returnsundefinedornull.Changes
r.id != null) before accessingidpropertyr.id.toString()toString(r.id)for safer type conversionTesting
idmight be undefinedRelated Issues
Closes #1678