-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update python prefabs #125
Open
adagolodjo
wants to merge
37
commits into
master
Choose a base branch
from
update_python_prefabs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve remaining bugs related to SoftRobot plugin compilation issues…
….Cosserat into update_python_prefabs
…ify object creation
Simplify BeamGeometryParameters by removing unnecessary attributes and defaults.
Refactor: Move rigid node creation to `utils.py` and simplify `CosseratBase`.
…eters and Cosserat prefab
Refactor: Move rigid node creation to `utils.py` and simplify `CosseratBase`.
…eters and Cosserat prefab
Cleanning the prefab class and update the test scene regarding
…te_python_prefabs
Let me know if you'd like to refine this further!
Refactor event key handling and add new cable-driven Cosserat beam scene - Updated key event handling in geo_cable_driven_cosserat_beam.py to use string-based key comparison for + and - keys. - Fixed minor formatting issue by adding missing comma in RestShapeSpringsForceField. - Added new scene file geo_cosserat_cable_driven_cosserat_beam.py for simulating cable-driven Cosserat beams, with detailed parameter definitions for beam geometry and physics. - Introduced PullingCosseratCable controller in pulling_cosserat_cable.py to handle cable pulling mechanics. - Replaced BeamPhysicsParameters with BeamPhysicsParametersNoInertia in tuto_5.py for more specific physical simulations.
…g and fix typos - Changed 'beam_params' to 'params' in CosseratBase for better clarity. - Updated parameter references in tutorial scenes (tuto_4.py, tuto_5.py) to match new naming conventions. - Refined BeamPhysicsParameters to use NoInertia where applicable. - Fixed typos (e.g., 'rotateFromEuler' comment and variable names like 'nbFrames' to 'nb_frames'). - Added rigid base spring force field in CosseratBase for better beam control. - Organized imports and cleaned up unused variables in the tutorial scenes.
Modify addFEMObject function to return solver and points nodes Update beam parameters in tutorial scenes (tuto_3, tuto_4, tuto_5) Refactor FEM object creation in tuto_5 scene Adjust cable constraint parameters and mapping in tuto_5 Minor code cleanup and parameter naming consistency improvements
- Disabled `printLog` in `SparseLDLSolver` within `header.py` for cleaner output. - Set `root_node.gravity` to `[0, -9.81, 0]` in `tuto_5.py` for realistic gravitational effect. - Added flexibility in constraint setup for `cable_node` by introducing `is_constrained` parameter. - Included missing `return root_node` statement to ensure complete scene creation in `createScene()`.
Added new functions attach_mesh_with_springs, attach_3d_points_to_meca_with_barycentric_mapping, and add_finger_mesh_force_field_Object to modularize and simplify FEM mesh handling and visualization. Introduced show_mecha_visual for toggling visibility of mechanical objects and indices. Replaced addFEMObject with add_finger_mesh_force_field_Object for improved clarity and functionality. Updated tuto_5.py to utilize new FEM mesh functions, enabling better integration and enhanced visualization. Removed redundant code and refactored solver and geometry attachment logic for better maintainability.
alxbilger
reviewed
Dec 3, 2024
… rename file - Renamed `wip/PCS_Example3.py` to `PCS_Example3.py` for clarity and organization. - Removed commented-out and unused code for better readability. - Fixed variable name `force` to `forces` and corrected index handling in `ForceController`. - Adjusted references from `nonLinearCosserat` to `PCS_Cosserat`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.