fix(seo): map zh-CN locale to zh for OG image filenames#244
Open
evan188199-tech wants to merge 1 commit into
Open
fix(seo): map zh-CN locale to zh for OG image filenames#244evan188199-tech wants to merge 1 commit into
evan188199-tech wants to merge 1 commit into
Conversation
The OG image file is named default-og-image_zh.jpg, but page.tsx and two spots in structured-data.ts interpolated the raw locale into the filename, producing default-og-image_zh-CN.jpg for the zh-CN locale — a file that doesn't exist, so the home page's social card image was broken for Chinese users. The codebase already applies the zh-CN → zh mapping in 5 other places (layout.tsx, SEOHead.tsx, structured-data.ts:269); apply it here too. Fixes Snouzy#243
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
此 PR 由 GLM-5.2 修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The home page's OpenGraph / Twitter card image was broken for the zh-CN locale, because
page.tsxand two spots instructured-data.tsinterpolated the raw locale into the filename (default-og-image_zh-CN.jpg) while the actual file isdefault-og-image_zh.jpg.Root cause
app/[locale]/(app)/page.tsx(lines 34, 44):For
locale === "zh-CN"this producesdefault-og-image_zh-CN.jpg— doesn't exist. The codebase already handles this mismatch in 5 other places (locale === "zh-CN" ? "zh" : locale):app/[locale]/layout.tsx:157src/components/seo/SEOHead.tsx:49,183src/shared/lib/structured-data.ts:269…but misses it in:
app/[locale]/(app)/page.tsx:34,44(home page metadata)src/shared/lib/structured-data.ts:219,250(structured data)Fix
Apply the same
zh-CN→zhmapping in all 4 missed spots.Fixes #243.