Skip to content

fix(workout-session): require auth + ownership to delete a workout session #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evan188199-tech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(workout-session): require auth + ownership to delete a workout session #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/features/workout-session/actions/delete-workout-session.action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
import { z } from "zod";

import { prisma } from "@/shared/lib/prisma";
import { actionClient } from "@/shared/api/safe-actions";
import { authenticatedActionClient } from "@/shared/api/safe-actions";

const deleteWorkoutSessionSchema = z.object({
id: z.string(),
});

export const deleteWorkoutSessionAction = actionClient.schema(deleteWorkoutSessionSchema).action(async ({ parsedInput }) => {
export const deleteWorkoutSessionAction = authenticatedActionClient.schema(deleteWorkoutSessionSchema).action(async ({ parsedInput, ctx }) => {
try {
const { id } = parsedInput;

Expand All @@ -18,7 +18,9 @@ export const deleteWorkoutSessionAction = actionClient.schema(deleteWorkoutSessi
select: { userId: true },
});

if (!session) {
// Return the same error for missing and non-owned sessions so the endpoint
// cannot be used to disclose which session ids exist.
if (!session || session.userId !== ctx.user.id) {
console.error("❌ Session not found:", id);
return { serverError: "Session not found" };
}
Expand Down