fix(env): read correct env var for bottom BMI banner ad slot#237
Open
evan188199-tech wants to merge 1 commit into
Open
fix(env): read correct env var for bottom BMI banner ad slot#237evan188199-tech wants to merge 1 commit into
evan188199-tech wants to merge 1 commit into
Conversation
NEXT_PUBLIC_BOTTOM_BMI_BANNER_AD_SLOT was mapped to process.env.NEXT_PUBLIC_TOP_BMI_BANNER_AD_SLOT (copy/paste), so setting the bottom slot had no effect and both BMI ad slots showed the top slot's ad. Fixes Snouzy#236
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
此 PR 由 GLM-5.2 修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NEXT_PUBLIC_BOTTOM_BMI_BANNER_AD_SLOTwas mapped to the TOP env var instead of the BOTTOM one — a copy/paste error insrc/env.ts.Impact
Setting
NEXT_PUBLIC_BOTTOM_BMI_BANNER_AD_SLOThas no effect — the bottom BMI ad slot always gets the top slot's value, so a publisher configuring different ads for top vs. bottom sees the same ad in both positions.Fix
One line — map it to the correct env var:
I scanned the rest of
experimental__runtimeEnvfor the same key/value mismatch pattern — this was the only one.Fixes #236.