fix(locales): enable English fallback for missing translation keys#235
Open
evan188199-tech wants to merge 1 commit into
Open
Conversation
The fallbackLocale option in createI18nClient was commented out, so any translation key missing from a non-English locale rendered as its raw dotted path (e.g. 'heatmap.no_workout') instead of falling back to the English text. 138 keys are currently affected across es/pt/ru/fr. Enable fallbackLocale: en so missing keys show English instead of raw paths. Fixes Snouzy#234
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
此 PR 由 GLM-5.2 修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Missing translation keys render as raw key paths (e.g.
heatmap.no_workout) instead of falling back to English, because thefallbackLocaleoption is commented out inlocales/client.ts.Root cause
next-international'screateI18nClientsupportsfallbackLocale, which makes missing keys fall back to the specified locale. It's disabled, so every untranslated key shows its raw dotted path.138 keys are currently missing across es/pt/ru/fr (zh-CN partially covered by #200). Examples showing as raw paths today:
heatmap.no_workout/heatmap.one_workout_unit/heatmap.multiple_workouts_unithealth_risks.overweight.*/health_risks.underweight.*(~25 each, BMI results page)commons.refresh,workout_builder.muscles.latsFix
One line — uncomment and enable:
This immediately improves every locale (and future ones): missing keys show English instead of raw paths. Complementary to translation-completion PRs like #200 — the fallback is a safety net for any key not yet translated.
Fixes #234.