fix(programs): set suggested set programExerciseId to the real exercise id#229
Open
evan188199-tech wants to merge 1 commit into
Open
Conversation
…se id get-session-by-slug mapped each suggested set's programExerciseId from set.programSessionExerciseId, i.e. the parent ProgramSessionExercise id (ex.id) — the same value it already assigned to programSessionExerciseId one line above. ProgramSuggestedSet has no such column, so the field is synthesized, and it was synthesized to the wrong value (always mirroring the session-exercise id). Use ex.exerciseId (the underlying Exercise id) instead. Fixes Snouzy#228
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
此 PR 由 GLM-5.2 修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
get-session-by-slug.action.ts, each suggested set'sprogramExerciseIdis filled with the session-exercise id instead of a program-exercise reference — a copy/paste assigning the same value to two fields.set.programSessionExerciseIdis the parentProgramSessionExercise.id(ex.id). TheProgramSuggestedSetmodel has noprogramExerciseIdcolumn, so the field is synthesized — and it's synthesized to the wrong value: it always mirrorsprogramSessionExerciseId. The real program-exercise identity in this scope isex.exerciseId(the underlyingExercise.id).Impact
Latent: the current
ProgramSessionClientdoesn't readprogramExerciseId(it consumestypes/valuesInt/valuesSec/units), so today's UI is unaffected. ButSuggestedSetdeclares the field, so any future consumer or test gets a silently wrong value.Fix
Carry the parent's real exercise id into the mapped set:
Fixes #228.