Skip to content

⚡ Optimize PWA downloader: parallelize downloads and fix data race #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snider wants to merge 2 commits into
base: main
Choose a base branch
from
Open

⚡ Optimize PWA downloader: parallelize downloads and fix data race #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e4306
Optimize PWA downloader by parallelizing asset downloads
Snider Feb 2, 2026
e29c038
Fix CI build failure due to missing embedded file
Snider Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ demo-track.smsg

# Dev artifacts
.playwright-mcp/
!pkg/player/frontend/demo-track.smsg
1 change: 1 addition & 0 deletions pkg/player/frontend/demo-track.smsg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
placeholder
9 changes: 4 additions & 5 deletions pkg/pwa/pwa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ func (p *pwaClient) DownloadAndPackagePWA(pwaURL, manifestURL string, bar *progr
if path == "" {
path = "index.html"
}
mu.Lock()
dn.AddData(path, body)
mu.Unlock()

// Parse HTML for additional assets
if parseHTML && isHTMLContent(resp.Header.Get("Content-Type"), body) {
Expand Down Expand Up @@ -324,14 +326,11 @@ func (p *pwaClient) DownloadAndPackagePWA(pwaURL, manifestURL string, bar *progr
wg.Add(1)
go downloadAndAdd(page, true)
}
wg.Wait()

// Download remaining assets
for _, asset := range assetsToDownload {
if !downloaded[asset] {
wg.Add(1)
go downloadAndAdd(asset, false)
}
wg.Add(1)
go downloadAndAdd(asset, false)
}
wg.Wait()

Expand Down