Skip to content

⚡ Optimize regex compilation in PWA service worker detection #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snider wants to merge 2 commits into
base: main
Choose a base branch
from
Open

⚡ Optimize regex compilation in PWA service worker detection #107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2b0c80
Optimize regex compilation in PWA service worker detection
Snider Feb 2, 2026
6da71b2
Optimize regex compilation in PWA and fix player build
Snider Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions pkg/pwa/pwa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,14 +418,14 @@ func (p *pwaClient) extractAssetsFromHTML(baseURL string, htmlContent []byte) []
return assets
}

// serviceWorkerPatterns contains pre-compiled regex for detecting service workers.
var serviceWorkerPatterns = []*regexp.Regexp{
regexp.MustCompile(`navigator\.serviceWorker\.register\(['"]([^'"]+)['"]`),
regexp.MustCompile(`serviceWorker\.register\(['"]([^'"]+)['"]`),
}

// detectServiceWorker tries to find service worker registration in HTML/JS.
func (p *pwaClient) detectServiceWorker(baseURL string, dn *datanode.DataNode) string {
// Look for common service worker registration patterns
patterns := []string{
`navigator\.serviceWorker\.register\(['"]([^'"]+)['"]`,
`serviceWorker\.register\(['"]([^'"]+)['"]`,
}

// Check all downloaded HTML and JS files
err := dn.Walk(".", func(path string, d fs.DirEntry, err error) error {
if err != nil {
Expand All @@ -445,8 +445,7 @@ func (p *pwaClient) detectServiceWorker(baseURL string, dn *datanode.DataNode) s
return nil
}

for _, pattern := range patterns {
re := regexp.MustCompile(pattern)
for _, re := range serviceWorkerPatterns {
matches := re.FindSubmatch(content)
if len(matches) > 1 {
swPath := string(matches[1])
Expand Down
Loading