Skip to content

Conversation

@fordmadox
Copy link
Contributor

…erPro date for ASpace consumption

Description

This commit includes the XSLT files used to convert Excel output from FileMakerPro to EAD2002 for ingest into ASpace, as part of the NASM Technical Reference Files project.

This process still needs documentation, plus an explanation of the source data. For now, I just wanted to get the file versioned, in case NASM requests any changes.

Related GitHub Issue

Testing

Not automated tests added yet. Testing was manual and with the assistance of NASM, thus far.

Screenshot(s):

Checklist

  • ✔️ Have you assigned at least one reviewer?
  • 🔗 Have you referenced any issues this PR will close?
  • ⬇️ Have you merged the latest upstream changes into your branch?
  • 🧪 Have you added tests to cover these changes? If not, why:
  • 📘 Have you updated/added any relevant readmes/wiki pages/comments in the codebase?
  • 📚 Have you updated/added any external documentation (e.g. Confluence, AirTable, GitHub Projects)?

@fordmadox fordmadox linked an issue Apr 9, 2025 that may be closed by this pull request
@fordmadox fordmadox requested a review from lorawoodford April 9, 2025 12:52
Copy link
Contributor

@lorawoodford lorawoodford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fordmadox Looks good. We might consider either 1) adding a README to this new xslt_scripts directory, or 2) adding something to the wiki about this and future transformation files. We don't want to be bogged down with documentation, but we also may want some description of what these things were for when we look back at them years in the future.

@lorawoodford
Copy link
Contributor

Oh, and an additional comment (that doesn't change my approval) but if we're sticking with the xslt directory location for this and future files, we can file a quick ticket to skip running the python linter and unit tests when a commit only includes changes to the xslt dir. There's no need to run those checks (or get failures) when the only modifications are to xslt files. The small task could be a chance for @crugas to get some actions experimentation in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push XSL file used for creating groups from FileMaker Pro extract

2 participants