Matter Lock: Allow subscription updates after modular-to-modular profile updates #2446
+129
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files 455 suites 0s ⏱️ Results for commit d891f62. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d891f62 |
HunsupJung
approved these changes
Oct 10, 2025
hcarter-775
commented
Oct 11, 2025
| @@ -1,27 +0,0 @@ | |||
| id: lockAlarm | |||
There was a problem hiding this comment.
this capability now exists and is used throughout the driver using an updated definition. Removing this embedded def that is only used in the test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On top of checking whether a profile id has changed, this checks whether the stored
profile.componentshas changed, specifically for hubs on 0.58 or greater. This would be useful for a modular profile update where the id has not changed, but new optional capabilities are included in the inventory sync. (For example, permitting a modular fingerprint in some cases).Summary of Completed Tests
Tested by adding a lock-modular fingerprint on a driver running on the hub 58 FW. When the profile update occurred, I confirmed the subscription updated in the
infoChangedas expected.Regression tested by onboarding a device on the existing
base-lockfingerprint and checking for the same results as the above.